Fix srd-2024 Fighter and Monk saving_throws to match their Core Traits tables#962
Closed
half-ogre wants to merge 1 commit into
Closed
Fix srd-2024 Fighter and Monk saving_throws to match their Core Traits tables#962half-ogre wants to merge 1 commit into
half-ogre wants to merge 1 commit into
Conversation
…s tables
The structured saving_throws fields for the 2024 Fighter and Monk
contradict the classes' own core-traits feature tables (and the SRD 5.2
Core Traits tables):
- Fighter: [dex, str] -> [con, str] ("Saving Throw Proficiencies:
Strength and Constitution")
- Monk: [dex, wis] -> [dex, str] ("Saving Throw Proficiencies:
Strength and Dexterity")
The other ten srd-2024 classes' fields already match their prose.
Author
|
Sorry for the noise here, I was exploring your data with Claude and it over-eagerly opened a PR before I was ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The structured
saving_throwsfields for two srd-2024 classes contradict the classes' owncore-traitsfeature tables (and the SRD 5.2 Core Traits tables in the CC document):saving_throwsfield["dex", "str"]["dex", "wis"]This PR corrects both fields (
["con", "str"]and["dex", "str"], keeping the existing array ordering style). I swept all twelve srd-2024 classes against their own core-traits prose — the other ten fields already match.Found while using the srd-2024 document as the verification source for a downstream 5e engine — thanks for maintaining this dataset; the verbatim rules text has been flawless in our audits.