Skip to content

fix: correct README grammar - #337

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-readme-grammar
Aug 4, 2026
Merged

fix: correct README grammar#337
jbeckwith-oai merged 1 commit into
mainfrom
codex/fix-readme-grammar

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • fix subject-verb agreement in the README's undocumented-parameter guidance

Why

The sentence uses the plural subject parameters, so the verb should be override, not overrides.

This intentionally uses a conventional fix: commit so that, after merge, Release Please should create or update a patch release PR through the new GitHub App authentication path.

Validation

  • git diff --check
  • thermo-nuclear code quality review
  • README-only one-word substitution

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review August 4, 2026 21:50
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 4, 2026 21:50
@jbeckwith-oai
jbeckwith-oai enabled auto-merge August 4, 2026 21:51
@openai-sdks

openai-sdks Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 9.06s for Ruby SDK PR #337.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 168ms
tests/chat-completions-create.test.ts ✅ Passed 259ms
tests/chat-completions-stream.test.ts ✅ Passed 135ms
tests/files-content-binary.test.ts ✅ Passed 298ms
tests/files-create-multipart.test.ts ✅ Passed 256ms
tests/files-list-pagination.test.ts ✅ Passed 176ms
tests/initialize-config.test.ts ✅ Passed 166ms
tests/instance-isolation.test.ts ✅ Passed 213ms
tests/models-list.test.ts ✅ Passed 267ms
tests/responses-background-lifecycle.test.ts ✅ Passed 228ms
tests/responses-body-method-errors.test.ts ✅ Passed 452ms
tests/responses-cancel-timeout.test.ts ✅ Passed 227ms
tests/responses-cancel.test.ts ✅ Passed 257ms
tests/responses-compact-retries.test.ts ✅ Passed 293ms
tests/responses-compact.test.ts ✅ Passed 267ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 199ms
tests/responses-create-advanced.test.ts ✅ Passed 172ms
tests/responses-create-disconnect.test.ts ✅ Passed 162ms
tests/responses-create-errors.test.ts ✅ Passed 267ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 139ms
tests/responses-create-retries.test.ts ✅ Passed 283ms
tests/responses-create-stream-failures.test.ts ✅ Passed 156ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 223ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.079s
tests/responses-create-stream.test.ts ✅ Passed 97ms
tests/responses-create-terminal-states.test.ts ✅ Passed 272ms
tests/responses-create-timeout.test.ts ✅ Passed 225ms
tests/responses-create.test.ts ✅ Passed 334ms
tests/responses-delete.test.ts ✅ Passed 353ms
tests/responses-input-items-errors.test.ts ✅ Passed 202ms
tests/responses-input-items-list.test.ts ✅ Passed 180ms
tests/responses-input-items-options.test.ts ✅ Passed 218ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 261ms
tests/responses-input-tokens-count.test.ts ✅ Passed 232ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.314s
tests/responses-not-found-errors.test.ts ✅ Passed 392ms
tests/responses-parse.test.ts ✅ Passed 195ms
tests/responses-retrieve-retries.test.ts ✅ Passed 248ms
tests/responses-retrieve.test.ts ✅ Passed 245ms
tests/responses-stored-method-errors.test.ts ✅ Passed 742ms
tests/retry-behavior.test.ts ✅ Passed 1.925s
tests/sdk-error-shape.test.ts ✅ Passed 380ms

View OkTest run #30954036684

SDK merge (a13dd9647f88) · head (bb71ded02e6e) · base (e53459fe858e) · OkTest (91635c6a2723)

@HAYDEN-OAI HAYDEN-OAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff: README.md correctly fixes plural subject-verb agreement (overrides -> override). No generated artifacts, release manifests, version files, gemspec, or packaging configuration are modified. The intentional fix: commit and matching PR title preserve the conventional commit after squash merge and exercise the newly merged GitHub App-authenticated Release Please path for the expected 0.77.1 patch-release PR. No substantive findings.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit a1cf585 Aug 4, 2026
14 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/fix-readme-grammar branch August 4, 2026 21:59
@openai-sdks openai-sdks Bot mentioned this pull request Aug 4, 2026
@jbeckwith-oai jbeckwith-oai added the generator Touches generated SDK files label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generator Touches generated SDK files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants