fix(internal): encode nested multipart fields with bracket notation - #339
Open
leoplct wants to merge 1 commit into
Open
fix(internal): encode nested multipart fields with bracket notation#339leoplct wants to merge 1 commit into
leoplct wants to merge 1 commit into
Conversation
The OpenAI API expects nested fields in multipart/form-data bodies to be
flattened deepObject-style (e.g. `expires_after[anchor]=created_at`),
but nested hashes were serialized as a single JSON part, which the API
rejects with "Additional properties are not allowed ('expires_after'
was unexpected)".
Flatten nested hashes and arrays inside multipart bodies using bracket
notation, matching openai-python's `_serialize_multipartform`
(qs "brackets" array format). Top-level primitive arrays keep the
existing repeated-key encoding.
Fixes openai#212
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nc2s6tXUGssbrFoafV34Rj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAI API expects nested fields in multipart/form-data bodies to be flattened deepObject-style (e.g.
expires_after[anchor]=created_at), but nested hashes were serialized as a single JSON part, which the API rejects with "Additional properties are not allowed ('expires_after' was unexpected)".Flatten nested hashes and arrays inside multipart bodies using bracket notation, matching openai-python's
_serialize_multipartform(qs "brackets" array format). Top-level primitive arrays keep the existing repeated-key encoding.Fixes #212