OBPIH-7952 Cycle Count - perform cc for item - #100
Open
kkrawczyk123 wants to merge 9 commits into
Open
Conversation
alannadolny
reviewed
Jul 30, 2026
alannadolny
reviewed
Jul 30, 2026
|
|
||
| getSectionNavItem(sectionName: string, itemName: string) { | ||
| return this.getSectionTitle(sectionName) | ||
| .locator('..') |
Collaborator
Author
There was a problem hiding this comment.
getNavItem(name) (line 26-28) searches for a menu item across the entire navbar. That's fine when item names are unique, but it breaks for names that also exist elsewhere — like "Reporting" appears both as a link inside the "Cycle Count" dropdown section and as a completely separate top-level "Reporting" module in the navbar. getNavItem('Reporting') would match both and throw a strict-mode violation.
| } | ||
|
|
||
| get table() { | ||
| return this.page.getByRole('grid'); |
Collaborator
There was a problem hiding this comment.
ehhh, as you said - I don't like that selector
|
|
||
| class ConfirmToCountTable extends BasePageModel { | ||
| get table() { | ||
| return this.page.locator('.count-step-table .ReactTable'); |
Collaborator
There was a problem hiding this comment.
I don't like this one also
|
|
||
| class ConfirmToRecountTable extends BasePageModel { | ||
| get table() { | ||
| return this.page.locator('.resolve-step-table .ReactTable'); |
Comment on lines
+70
to
+73
| // await test.step('Assert Last Counted date on All Products tab matches stock card', async () => { | ||
| // const row = manageCycleCountPage.allProductsTable.row(0); | ||
| // await expect(row.lastCounted).toHaveText(lastStockCountDate); | ||
| // }); |
| await expect(last.balance).toHaveText('50'); | ||
| }); | ||
|
|
||
| // await test.step('Assert Last Counted date and quantity on All Products tab', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added:
Assertion on last counted date is temporarily commented out because of an issue that I noticed when working on this test https://pihemr.atlassian.net/browse/OBPIH-7955