Skip to content

chore(deps/js): resolve npm audit vulnerabilities - #651

Open
SoulPancake wants to merge 5 commits into
mainfrom
fix/npm-audit-vulnerabilities
Open

chore(deps/js): resolve npm audit vulnerabilities#651
SoulPancake wants to merge 5 commits into
mainfrom
fix/npm-audit-vulnerabilities

Conversation

@SoulPancake

@SoulPancake SoulPancake commented Jul 30, 2026

Copy link
Copy Markdown
Member

Bumps js-yaml to ^4.3.0, clearing the 26 high severity advisories that are currently failing make audit-js on main.

Summary by CodeRabbit

  • Chores
    • Updated package configuration to use newer dependency versions.
    • Added an override for brace-expansion to improve dependency consistency.

Override brace-expansion to ^5.0.9 and js-yaml to ^4.3.0 to clear 26 high
severity advisories reported by npm audit.
@SoulPancake
SoulPancake requested a review from a team as a code owner July 30, 2026 18:51
Copilot AI review requested due to automatic review settings July 30, 2026 18:51
@SoulPancake
SoulPancake requested a review from a team as a code owner July 30, 2026 18:51
@dosubot

dosubot Bot commented Jul 30, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about language Add Dosu to your team

@SoulPancake SoulPancake changed the title fix(js): resolve npm audit vulnerabilities chore(deps/js): resolve npm audit vulnerabilities Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1eaa634-392c-4cc9-9114-af5522cc4cfa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The JavaScript package override configuration updates js-yaml to ^4.3.0 and adds a brace-expansion override pinned to ^5.0.9.

Changes

JavaScript dependency overrides

Layer / File(s) Summary
Override configuration
pkg/js/package.json
Updates the js-yaml override and adds the brace-expansion override.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aaguiarz, copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies JavaScript dependency updates that resolve npm audit vulnerabilities.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/npm-audit-vulnerabilities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JavaScript package’s dependency overrides to address npm audit findings in pkg/js/, bringing the JS workspace back to a clean security/audit state.

Changes:

  • Bump the js-yaml override from ^4.2.0 to ^4.3.0.
  • Add a brace-expansion override at ^5.0.9 to eliminate vulnerable transitive versions and update the lockfile accordingly.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/js/package.json Updates overrides to newer js-yaml and introduces brace-expansion override for audit remediation.
pkg/js/package-lock.json Reflects resolved dependency tree changes from the overrides (removes older nested vulnerable copies and pins updated versions).
Files not reviewed (1)
  • pkg/js/package-lock.json: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/js/package.json`:
- Line 56: Update the dependency configuration around brace-expansion and the
minimatch@3 consumers so brace-expansion@5 is not forced onto minimatch@3, which
requires a callable CommonJS export. Upgrade all affected minimatch consumers
together, or use an override/patch that preserves the callable API while
retaining compatibility.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d275fea8-7acb-4c8f-b93c-cb2c79e2f7b1

📥 Commits

Reviewing files that changed from the base of the PR and between 83fedf8 and 8bfa07e.

⛔ Files ignored due to path filters (1)
  • pkg/js/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • pkg/js/package.json

Comment thread pkg/js/package.json Outdated
brace-expansion@5 exports an object ({ expand, ... }) instead of a
callable CommonJS function. Forcing it onto minimatch@3.x consumers
(eslint, eslint-plugin-import, test-exclude, @eslint/*) made
`require('brace-expansion')(pattern)` throw
"TypeError: expand is not a function" for any pattern containing braces.

The override is unnecessary: minimatch@3.x requests ^1.1.7, which
resolves to the patched brace-expansion@1.1.18, and npm audit reports
0 vulnerabilities without it.
@SoulPancake
SoulPancake requested a review from rhamzeh August 1, 2026 05:49
Siddhant-K-code
Siddhant-K-code previously approved these changes Aug 5, 2026
@Siddhant-K-code

Copy link
Copy Markdown
Member

Please update PR description before merge! We are just bumping js-yaml

@SoulPancake
SoulPancake enabled auto-merge August 5, 2026 12:28
@SoulPancake

Copy link
Copy Markdown
Member Author

CC: @Siddhant-K-code
You can update this if you want

@Siddhant-K-code

Copy link
Copy Markdown
Member

I prepared the requested refresh in #663. It merges the current main fixes into this branch and raises the js-yaml override to ^4.3.1; the JS audit, lint, formatting, typecheck/build, and tests all pass. Direct push access to this upstream branch was unavailable, so merging #663 will update this PR.

Siddhant-K-code added a commit that referenced this pull request Aug 18, 2026
* chore(deps): bump the dependencies group with 3 updates (#658)

Bumps the dependencies group with 3 updates: [actions/setup-java](https://github.com/actions/setup-java), [gradle/actions/wrapper-validation](https://github.com/gradle/actions) and [gradle/actions/setup-gradle](https://github.com/gradle/actions).


Updates `actions/setup-java` from 5.6.0 to 5.7.0
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@03ad4de...b6effb0)

Updates `gradle/actions/wrapper-validation` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

Updates `gradle/actions/setup-gradle` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/wrapper-validation
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/setup-gradle
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js (#655)

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(deps): resolve JavaScript audit vulnerabilities (#659)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siddhant Khare <siddhant.khare@okta.com>

* fix(js): require patched js-yaml version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 18, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Siddhant-K-code / name: Siddhant Khare (7404696, bf63220)
  • ✅ login: SoulPancake / name: Anurag Bandyopadhyay (f9525d0)
  • ✅ login: SoulPancake / name: SoulPancake (6627b6a, 8bfa07e)
  • ✅ login: dependabot[bot] / name: dependabot[bot] (bf63220)

Siddhant-K-code added a commit that referenced this pull request Aug 18, 2026
* chore(deps): bump the dependencies group with 3 updates (#658)

Bumps the dependencies group with 3 updates: [actions/setup-java](https://github.com/actions/setup-java), [gradle/actions/wrapper-validation](https://github.com/gradle/actions) and [gradle/actions/setup-gradle](https://github.com/gradle/actions).

Updates `actions/setup-java` from 5.6.0 to 5.7.0
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@03ad4de...b6effb0)

Updates `gradle/actions/wrapper-validation` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

Updates `gradle/actions/setup-gradle` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/wrapper-validation
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/setup-gradle
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js (#655)

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(deps): resolve JavaScript audit vulnerabilities (#659)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siddhant Khare <siddhant.khare@okta.com>

* fix(js): require patched js-yaml version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Siddhant-K-code
Siddhant-K-code force-pushed the fix/npm-audit-vulnerabilities branch from 1d2f340 to e640286 Compare August 18, 2026 07:43
Siddhant-K-code and others added 2 commits August 18, 2026 13:18
* chore(deps): bump the dependencies group with 3 updates (#658)

Bumps the dependencies group with 3 updates: [actions/setup-java](https://github.com/actions/setup-java), [gradle/actions/wrapper-validation](https://github.com/gradle/actions) and [gradle/actions/setup-gradle](https://github.com/gradle/actions).

Updates `actions/setup-java` from 5.6.0 to 5.7.0
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@03ad4de...b6effb0)

Updates `gradle/actions/wrapper-validation` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

Updates `gradle/actions/setup-gradle` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](gradle/actions@3f131e8...9c97196)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/wrapper-validation
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: gradle/actions/setup-gradle
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js (#655)

* chore(deps): bump fast-uri from 3.1.4 to 3.1.5 in /pkg/js

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(deps): resolve JavaScript audit vulnerabilities (#659)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(js): require patched js-yaml version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Siddhant-K-code
Siddhant-K-code force-pushed the fix/npm-audit-vulnerabilities branch from e640286 to 7404696 Compare August 18, 2026 07:49
@Siddhant-K-code

Copy link
Copy Markdown
Member

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants