Skip to content

fix(js): update vulnerable transitive dependencies - #662

Closed
Siddhant-K-code wants to merge 1 commit into
openfga:developfrom
Siddhant-K-code:fix/js-audit-vulnerabilities
Closed

fix(js): update vulnerable transitive dependencies#662
Siddhant-K-code wants to merge 1 commit into
openfga:developfrom
Siddhant-K-code:fix/js-audit-vulnerabilities

Conversation

@Siddhant-K-code

Copy link
Copy Markdown
Member

Description

Fixes the JavaScript dependency-audit failure observed in #652 by refreshing compatible transitive versions in pkg/js/package-lock.json:

  • brace-expansion: 1.1.18 and 5.0.9
  • fast-uri: 3.1.5
  • js-yaml: 4.3.1

These are the first compatible versions outside the advisory ranges reported by npm. No direct dependency ranges or runtime code change.

Failing job: https://github.com/openfga/language/actions/runs/32035329850/job/95404310045?pr=652

Testing

Using the CI runtime versions (Node 24.19.0 and npm 11.17.0):

  • npm ci
  • npm audit — 0 vulnerabilities
  • npm run lint
  • npm run format:check
  • npm run typecheck
  • npm run build:light
  • npm test -- --runInBand — 666 passed, 27 skipped

Co-authored-by: Codex <noreply@openai.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 06:25
@Siddhant-K-code
Siddhant-K-code requested review from a team as code owners August 18, 2026 06:25
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3435a90-a6fe-494b-b377-1bbbed95ca00

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • pkg/js/package-lock.json: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SoulPancake

SoulPancake commented Aug 18, 2026

Copy link
Copy Markdown
Member

Lets hold these off @Siddhant-K-code
I already have the audit failures in a separate PR #660

Edit : Theres nothing immediately to release in pkg js in develop anyway so we can skip this for the moment

@Siddhant-K-code

Siddhant-K-code commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

I already have the audit failures in a separate PR #660

We can separate it out as it is not needed to go in same PR!

Edit : Theres nothing immediately to release in pkg js in develop anyway so we can skip this for the moment

It has security fixes & affecting PRs with CI failures

@SoulPancake

Copy link
Copy Markdown
Member

It's not really required in the develop flow, If you want you can add it in main @Siddhant-K-code

@SoulPancake

SoulPancake commented Aug 18, 2026

Copy link
Copy Markdown
Member

It has security fixes & affecting PRs with CI failures

I agree but it won't matter until we release, if you want you can do it on main

@Siddhant-K-code
Siddhant-K-code deleted the fix/js-audit-vulnerabilities branch August 18, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants