8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809jerboaa wants to merge 1 commit into
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
0dc5b58 to
fbe874a
Compare
b09f14a to
a18ae0c
Compare
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
ee90e96 to
689fa41
Compare
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
a18ae0c to
42fe7f9
Compare
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Clean (modulo path changes) test-only backport for bringing in JDK-8284047. In particular, this is preparatory work for JDK-8263188 a dependency for JDK-8284047.
Testing
Thoughts?
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/809/head:pull/809$ git checkout pull/809Update a local copy of the PR:
$ git checkout pull/809$ git pull https://git.openjdk.org/jdk8u-dev.git pull/809/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 809View PR using the GUI difftool:
$ git pr show -t 809Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/809.diff
Using Webrev
Link to Webrev Comment