Add chain parameter to Material.get_activity for half-life data#3957
Open
EdenRochmanSharabi wants to merge 1 commit into
Open
Add chain parameter to Material.get_activity for half-life data#3957EdenRochmanSharabi wants to merge 1 commit into
EdenRochmanSharabi wants to merge 1 commit into
Conversation
When a depletion chain is provided, half-life values from the chain are preferred over the default ENDF/B-VIII.0 values. This allows users to compute activity using chain-specific nuclear data. For nuclides not found in the chain, the default values are used as a fallback. The same parameter is also added to Results.get_activity. Closes openmc-dev#3529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainparameter toMaterial.get_activity()andResults.get_activity()that accepts a depletion chain (object or path to XML)openmc.data.decay_constant()Test plan
get_activity()withoutchainparameter produces identical results to current behaviorget_activity(chain=chain)uses chain half-life valuesResults.get_activity(chain=...)passes the parameter through correctlyCloses #3529