fix: clusteraccess lib deletes and recreates (Cluster)RoleBinding resources if roleRef changed#245
Merged
Conversation
ValentinGerlach
approved these changes
Jun 12, 2026
…s if roleRef changed Signed-off-by: Johannes Aubart <johannes.aubart@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
clusteraccesslibrary has functions for creating and updatingRoleBindingandClusterRoleBindingresources. These did not consider the fact that theroleReffield of these resources is immutable, leading to a persistent error if the caller of the functions changes the role ref of an existing (Cluster)RoleBinding. This PR fixes that.Which issue(s) this PR fixes:
Basically the fix for openmcp-project/cluster-provider-gardener#234.
Special notes for your reviewer:
Release note: