Allow bulk shard failures without shard id#2023
Open
smf-h wants to merge 1 commit into
Open
Conversation
smf-h
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: smf-h <692979649@qq.com>
smf-h
force-pushed
the
ix-bulk-shard-search-failure-optional-shard
branch
from
f2a9ef6 to
ef1f0f3
Compare
reta
requested changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551.
This keeps the change scoped to
_common.ShardSearchFailure, which is the failure type used by the bulk response path throughBulkResponse._shards.failures. It does not change_common.ShardFailure.ShardSearchFailure.shard()is now a nullableIntegerso bulk shard failures that omitsharddeserialize successfully asnull, while responses that includeshardstill preserve the value. This is a source compatibility note for callers that previously treatedshard()as a primitiveint.The generated Java mirror is backed by a Java-codegen override marking
_common.ShardSearchFailure.shardoptional. A follow-up in the API spec may be preferable if the upstream schema should represent this optionality directly.Validation caveat: cheap local gates passed (
git diff --checkand marker scan), but local:java-client:testcould not execute because this environment fails to load Gradle's JUnit 4 test framework; an existingPercentCodecTestfails with the same local loader error. This should be confirmed with a clean CI/Linux focused test run.