Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .tekton/hyperfleet-adapter-chart-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ spec:
- name: name
value: prefetch-dependencies-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:3dc78afbf3a441e0280067433cb28ea3d2d0088ec214c73bf063f145b4f273ef
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:7e84b01526b6a50b920c0f456c8d95d6c5c2f7b81109ea772e1dcf7aba14bfa5
- name: kind
value: task
resolver: bundles
Expand All @@ -170,7 +170,7 @@ spec:
- name: name
value: build-helm-chart-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-build-helm-chart-oci-ta:0.3@sha256:d3d7e1892617fb1c057f1910715cb8bb4f980f43135ab482e88d0299effdc473
value: quay.io/konflux-ci/tekton-catalog/task-build-helm-chart-oci-ta:0.3@sha256:da8946625604bb4851466cbb163df69f4f9cd973845dfb042cf1c80cecb84bac
- name: kind
value: task
resolver: bundles
Expand All @@ -193,7 +193,7 @@ spec:
- name: name
value: sast-shell-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:3cbb3535af6e7d4396858179a6427caaffb2e68775594795692fc01f28ae313f
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:e5319fccebd21a1b06eb8fa6a46b78d745ce87464ed2cdd08b5f68a4489e2f14
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -221,7 +221,7 @@ spec:
- name: name
value: sast-unicode-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:223812001607b07f0e07d56bef7b7d619144e660c0c57f21ddd44ce0c8c4785b
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:99cc3729af9c3e1e6821e07e4d46cc0366a43d53cfba42846c0461abb68b5362
- name: kind
value: task
resolver: bundles
Expand Down
14 changes: 7 additions & 7 deletions .tekton/hyperfleet-adapter-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ spec:
- name: name
value: prefetch-dependencies-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:3dc78afbf3a441e0280067433cb28ea3d2d0088ec214c73bf063f145b4f273ef
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:7e84b01526b6a50b920c0f456c8d95d6c5c2f7b81109ea772e1dcf7aba14bfa5
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -231,7 +231,7 @@ spec:
- name: name
value: buildah-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-buildah-oci-ta:0.9@sha256:75ecb662f343f6f34e553c5b37734d28d9b53ce218c2321a19b96c39bf769357
value: quay.io/konflux-ci/tekton-catalog/task-buildah-oci-ta:0.10@sha256:1d633027ed426996720890ec9a74576ae264d711a177bf18f39a5a9e8023435c

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Konflux tekton-catalog task-buildah-oci-ta 0.10 migration guide from 0.9 (required parameter/result/workspace changes)

💡 Result:

Required parameter/result/workspace changes for task-buildah-oci-ta:0.10 (Konflux tekton-catalog) migrating from 0.9: 1) Runner image change (impacts how the task runs, not pipeline params/workspaces) - In buildah*/0.10, the buildah task image is replaced with konflux-build-cli (kbc-based flow). [1] - 0.10 now “sets runAsUser: 0 explicitly” (previously it ran as root implicitly), so if your pipeline/controller policies override securityContext you may need to re-check. [1] 2) Workspace binding change in the shipped pipelines - The docker-build-oci-ta pipeline customization patch for 0.10 removes a workspace binding at /spec/workspaces/0. That indicates pipelines upgrading to 0.10 should drop that workspace binding and rely on the task’s OCI-artifact/result-based data flow instead. [2] 3) Task results you must wire (result key names) - buildah-oci-ta:0.10 exposes results including IMAGE_DIGEST, IMAGE_REF, IMAGE_URL, and SBOM_BLOB_URL, and pipeline params can reference them by those result names. If your 0.9 pipeline referenced different result names, update them to the 0.10 keys. [3] 4) Behavior-affecting internal parameter handling (validate your overrides against the new semantics) - 0.10 changes multiple internal behaviors by passing values directly to kbc, including: a) annotations+labels handling via kbc. [4] b) hermetic mode handling via kbc. [5] c) prefetch integration via kbc. [6] d) working directory mount handling via kbc. [7] These may not require parameter schema changes, but they can affect behavior if your 0.9 pipeline depended on previous side-effects. What to do when migrating your pipeline from 0.9 -> 0.10: - Bump the task bundle version to task-buildah-oci-ta:0.10. [1] - Remove the pipeline workspace binding corresponding to /spec/workspaces/0 (as per the 0.10 pipeline patch). [2] - Update any task result references to use IMAGE_DIGEST / IMAGE_REF / IMAGE_URL / SBOM_BLOB_URL for buildah-oci-ta:0.10. [3] - Re-test/verify behavior for hermetic builds, prefetch, and annotations/labels if you set related params, because 0.10 routes these through kbc. [4][5][6] Note: build-definitions does include a per-task version MIGRATION.md file (task/buildah-oci-ta/0.10/MIGRATION.md), but in the retrieved sources for this run I did not get the MIGRATION.md contents themselves; the migration-impact items above are grounded in the 0.10 change commit notes and the published pipeline patch/README schemas. [1][3][2]

Citations:


🌐 Web query:

Konflux tekton-catalog task-sast-snyk-check-oci-ta 0.5 migration guide from 0.4 (required parameter/result/workspace changes)

💡 Result:

To migrate the Konflux tekton-catalog task sast-snyk-check-oci-ta from version 0.4 to 0.5, you should rely on the automated migration process provided by Konflux [1]. As of June 2026, version 0.5 of sast-snyk-check-oci-ta has been released in the konflux-sast-tasks repository [2]. Konflux automates task upgrades using the pipeline-migration-tool (pmt), which is integrated into the regular pull request workflow for updating Tekton tasks [1]. If you need to verify or apply these changes manually: 1. Locate the MIGRATION.md file within the task's directory in the konflux-sast-tasks source repository (specifically task/sast-snyk-check-oci-ta/0.5/MIGRATION.md) [2]. This file contains the authoritative, version-specific instructions regarding any required parameter, result, or workspace changes that may have been introduced in the 0.5 release. 2. If your automated build update is not triggering or applying correctly, you can use the pmt CLI tool in your component repository to apply the migration. You will need to generate the appropriate upgrade data—which maps the old bundle (0.4) to the new bundle (0.5)—and execute the pmt migrate command [1]. Because task migrations can involve specific breaking changes to inputs (parameters) or outputs (results), checking the MIGRATION.md file in the source repository is the mandatory step to ensure compatibility with your existing pipeline definition [1][2].

Citations:


🏁 Script executed:

#!/bin/bash
# Check for migration docs or upgrade notes related to the task versions
find . -type f -name "*.md" | xargs grep -l "migration\|upgrade\|0.10\|0.9" 2>/dev/null || echo "No migration docs found"

Repository: openshift-hyperfleet/hyperfleet-adapter

Length of output: 133


🏁 Script executed:

#!/bin/bash
# Check the actual pipeline file for workspace bindings and result usage
cat -n .tekton/hyperfleet-adapter-push.yaml | grep -A 5 -B 5 "workspaces\|results\|buildah-oci-ta"

Repository: openshift-hyperfleet/hyperfleet-adapter

Length of output: 11190


🏁 Script executed:

#!/bin/bash
# Verify current versions in hyperfleet-api
grep -n "buildah-oci-ta\|sast-snyk-check-oci-ta" .tekton/hyperfleet-api-push.yaml | head -20

Repository: openshift-hyperfleet/hyperfleet-api

Length of output: 469


🏁 Script executed:

#!/bin/bash
# Verify current versions in hyperfleet-sentinel
grep -n "buildah-oci-ta\|sast-snyk-check-oci-ta" .tekton/hyperfleet-sentinel-push.yaml | head -20

Repository: openshift-hyperfleet/hyperfleet-sentinel

Length of output: 474


Block merge until task-upgrade breaking changes are evaluated.

This PR upgrades buildah-oci-ta 0.9→0.10 and sast-snyk-check-oci-ta 0.4→0.5, both with documented breaking changes (CWE-829: Improper Initialization, CWE-436: Untrusted Input). No migration evidence exists in-repo:

  1. buildah-oci-ta 0.10 requires: runner image change to konflux-build-cli, workspace binding removal from spec, result references to IMAGE_URL/IMAGE_DIGEST/IMAGE_REF/SBOM_BLOB_URL, securityContext validation (now runs as root explicitly), and re-testing of hermetic/prefetch/annotations/labels behavior via kbc.

  2. sast-snyk-check-oci-ta 0.5 requires: automated migration via Konflux pmt tool against MIGRATION.md from konflux-sast-tasks source, with mandatory parameter/result/workspace validation.

  3. Platform version skew: hyperfleet-api and hyperfleet-sentinel remain pinned to 0.9 and 0.4 respectively. Post-merge, CI behavior diverges across services, creating integration risk.

PR objectives explicitly require migration-guide review. Verify all breaking changes are handled before unblocking.

References - buildah-oci-ta 0.10 changelog: https://github.com/konflux-ci/build-definitions/commit/09d4dc96a727135bed510140067cf40eab2f3819 - sast-snyk-check-oci-ta 0.5 migration: https://docs.konflux-ci.dev/apply-task-migrations/
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/hyperfleet-adapter-push.yaml at line 234, Before committing the task
version upgrades for buildah-oci-ta to 0.10 and sast-snyk-check-oci-ta to 0.5 in
the hyperfleet-adapter-push.yaml file, you must complete the breaking change
migrations documented in the task changelogs. For buildah-oci-ta 0.10, update
the runner image to konflux-build-cli, remove workspace bindings from the spec,
update all result references to use
IMAGE_URL/IMAGE_DIGEST/IMAGE_REF/SBOM_BLOB_URL, validate the securityContext
configuration, and test the hermetic, prefetch, annotations, and labels
behavior. For sast-snyk-check-oci-ta 0.5, run the automated migration using the
Konflux pmt tool against the MIGRATION.md file and validate all parameters,
results, and workspace configurations. Additionally, update the task versions in
hyperfleet-api and hyperfleet-sentinel configurations from 0.9 and 0.4
respectively to match the new versions (0.10 and 0.5) to eliminate platform
version skew. Document all migration changes with evidence in the repository
before unblocking the merge.

Source: Linked repositories

- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -338,7 +338,7 @@ spec:
- name: name
value: ecosystem-cert-preflight-checks
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:88f4fd6d7812a3c46f120f3035974f5fb8cb06b5e3e927badf6e8370f1516a88
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:3c4f60ebda2225eff6a6bc387d9bbd443f1264d756bf385f97cc684992e904a0
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -366,7 +366,7 @@ spec:
- name: name
value: sast-snyk-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check-oci-ta:0.4@sha256:0ebf28a0abd5a167438d4628938a74ade6f00a44a4b7ed1cfa9cfc57a5b24748
value: quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check-oci-ta:0.5@sha256:ba08e3b2dac65b0938ee312a9d6956770b98d99916100c2f9869f0090db3ad68
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -416,7 +416,7 @@ spec:
- name: name
value: sast-shell-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:3cbb3535af6e7d4396858179a6427caaffb2e68775594795692fc01f28ae313f
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:e5319fccebd21a1b06eb8fa6a46b78d745ce87464ed2cdd08b5f68a4489e2f14
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -444,7 +444,7 @@ spec:
- name: name
value: sast-unicode-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:223812001607b07f0e07d56bef7b7d619144e660c0c57f21ddd44ce0c8c4785b
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:99cc3729af9c3e1e6821e07e4d46cc0366a43d53cfba42846c0461abb68b5362
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -506,7 +506,7 @@ spec:
- name: name
value: rpms-signature-scan
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2@sha256:237c54b069d16c3785d1302f19be309aa6c0ae2313d446e30cb74671e07ca676
value: quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2@sha256:c78924dc4178da2356f4e8ee04e4ee5022e27851cc7d722765a2b0d337fdb069
- name: kind
value: task
resolver: bundles
Expand Down
14 changes: 7 additions & 7 deletions .tekton/hyperfleet-adapter-tag.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ spec:
- name: name
value: prefetch-dependencies-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:3dc78afbf3a441e0280067433cb28ea3d2d0088ec214c73bf063f145b4f273ef
value: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.3@sha256:7e84b01526b6a50b920c0f456c8d95d6c5c2f7b81109ea772e1dcf7aba14bfa5
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -261,7 +261,7 @@ spec:
- name: name
value: buildah-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-buildah-oci-ta:0.9@sha256:75ecb662f343f6f34e553c5b37734d28d9b53ce218c2321a19b96c39bf769357
value: quay.io/konflux-ci/tekton-catalog/task-buildah-oci-ta:0.10@sha256:1d633027ed426996720890ec9a74576ae264d711a177bf18f39a5a9e8023435c
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -368,7 +368,7 @@ spec:
- name: name
value: ecosystem-cert-preflight-checks
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:88f4fd6d7812a3c46f120f3035974f5fb8cb06b5e3e927badf6e8370f1516a88
value: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:3c4f60ebda2225eff6a6bc387d9bbd443f1264d756bf385f97cc684992e904a0
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -396,7 +396,7 @@ spec:
- name: name
value: sast-snyk-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check-oci-ta:0.4@sha256:0ebf28a0abd5a167438d4628938a74ade6f00a44a4b7ed1cfa9cfc57a5b24748
value: quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check-oci-ta:0.5@sha256:ba08e3b2dac65b0938ee312a9d6956770b98d99916100c2f9869f0090db3ad68
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -446,7 +446,7 @@ spec:
- name: name
value: sast-shell-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:3cbb3535af6e7d4396858179a6427caaffb2e68775594795692fc01f28ae313f
value: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:e5319fccebd21a1b06eb8fa6a46b78d745ce87464ed2cdd08b5f68a4489e2f14
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -474,7 +474,7 @@ spec:
- name: name
value: sast-unicode-check-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:223812001607b07f0e07d56bef7b7d619144e660c0c57f21ddd44ce0c8c4785b
value: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.4@sha256:99cc3729af9c3e1e6821e07e4d46cc0366a43d53cfba42846c0461abb68b5362
- name: kind
value: task
resolver: bundles
Expand Down Expand Up @@ -536,7 +536,7 @@ spec:
- name: name
value: rpms-signature-scan
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2@sha256:237c54b069d16c3785d1302f19be309aa6c0ae2313d446e30cb74671e07ca676
value: quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2@sha256:c78924dc4178da2356f4e8ee04e4ee5022e27851cc7d722765a2b0d337fdb069
- name: kind
value: task
resolver: bundles
Expand Down