Skip to content

chore(deps): update google.golang.org/genproto/googleapis/rpc digest to 87f3d3e#219

Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest
Open

chore(deps): update google.golang.org/genproto/googleapis/rpc digest to 87f3d3e#219
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest

Conversation

@red-hat-konflux-kflux-prd-rh02

@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
google.golang.org/genproto/googleapis/rpc indirect digest 9d38bb487f3d3e

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux-kflux-prd-rh02

red-hat-konflux-kflux-prd-rh02 Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -t ./...
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20260618152121-87f3d3e198d3
go: github.com/openshift-hyperfleet/hyperfleet-api/pkg/api imports
	github.com/openshift-hyperfleet/hyperfleet-api/pkg/api/openapi: cannot find module providing package github.com/openshift-hyperfleet/hyperfleet-api/pkg/api/openapi
go: module github.com/bxcodec/faker/v3 is deprecated: use github.com/go-faker/faker/v4 instead.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated an indirect project dependency to a newer version to improve stability and compatibility.

Walkthrough

go.mod replaces the existing indirect dependency version for google.golang.org/genproto/googleapis/rpc with a new pseudo-version referencing commit 87f3d3e198d3. No other dependencies, Go version, or directives are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Supply chain flag. This is a pseudo-version pinning to a raw commit hash (87f3d3e198d3) rather than a tagged release. Pseudo-versions bypass the semantic versioning guarantees that the Go module proxy enforces for tagged releases. Relevant risks: CWE-1104 (Use of Unmaintained Third-Party Components), CWE-494 (Download of Code Without Integrity Check) if the proxy cache is bypassed, and CWE-441 (Unintended Proxy) if the upstream domain is compromised.

Confirm:

  • go.sum was updated with the hash for commit 87f3d3e198d3 and is committed alongside this change.
  • The commit 87f3d3e198d3 is reachable on the public google.golang.org/genproto upstream — not a fork or shadow module.
  • This bump was intentional and not injected via an automated tool or CI bot without explicit review.
🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating a Google genproto dependency digest to a specific version hash.
Description check ✅ Passed The description is related to the changeset, detailing the dependency update with before/after digest values and automation context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed No log statements in the codebase expose tokens, passwords, credentials, or secrets. The PR modifies only go.mod (dependency update) without changing logging code. Secrets are properly redacted via...
No Hardcoded Secrets ✅ Passed Commit hash 87f3d3e198d3 in go.mod line 150 is public information. No hardcoded secrets (API keys, tokens, passwords, credentials) or suspicious patterns detected.
No Weak Cryptography ✅ Passed PR contains only a go.mod dependency version update; no code changes introduce weak cryptography. Existing codebase uses RS256 JWT validation without MD5, DES, RC4, or insecure comparison.
No Injection Vectors ✅ Passed No injection vectors detected. PR only modifies go.mod, go.sum, .bingo/ tooling configs, and other configuration files—no application source code containing SQL, exec.Command, template.HTML, or yam...
No Privileged Containers ✅ Passed Check is not applicable; PR only modifies go.mod (dependency update), not container configurations in Dockerfile, K8s manifests, or Helm templates.
No Pii Or Sensitive Data In Logs ✅ Passed No logging statements exposing PII or sensitive data found. Logging uses structured format with masking middleware; headers are redacted and no request/response bodies, credentials, or session IDs...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: updates to go.mod needed, disabled by -mod=readonly; to update it:\n\tgo mod tidy\n"


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from aredenba-rh and rh-amarin June 15, 2026 16:12
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tirthct for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…to 87f3d3e

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot force-pushed the konflux/mintmaker/main/google.golang.org-genproto-googleapis-rpc-digest branch from d9be8e2 to e3e3998 Compare June 22, 2026 00:18
@red-hat-konflux-kflux-prd-rh02 red-hat-konflux-kflux-prd-rh02 Bot changed the title Update google.golang.org/genproto/googleapis/rpc digest to 7ab31c2 chore(deps): update google.golang.org/genproto/googleapis/rpc digest to 87f3d3e Jun 22, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 150: The go.mod file has an invalid pseudo-version entry for the module
google.golang.org/genproto/googleapis/rpc. The current entry uses only a bare
commit hash (87f3d3e198d3) instead of the required Go pseudo-version format
(v0.0.0-YYYYMMDDHHMMSS-commithash). To fix this, run the command go get -m
google.golang.org/genproto/googleapis/rpc@87f3d3e198d3 which will automatically
resolve and update the dependency to the correct pseudo-version format with the
proper timestamp for that commit hash.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 04fb1953-7805-43fd-a785-095bdf56df3b

📥 Commits

Reviewing files that changed from the base of the PR and between d9be8e2 and e3e3998.

📒 Files selected for processing (1)
  • go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Comment thread go.mod
golang.org/x/text v0.35.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260401024825-9d38bb4040a9 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260401024825-9d38bb4040a9 // indirect
google.golang.org/genproto/googleapis/rpc 87f3d3e198d3 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Invalid pseudo-version syntax on google.golang.org/genproto/googleapis/rpc.

Line 150 is missing the required pseudo-version prefix. Go modules demand the format v0.0.0-YYYYMMDDHHMMSS-commithash. The current entry 87f3d3e198d3 is a bare commit hash and will fail go mod operations.

The old version follows the correct format: v0.0.0-20260401024825-9d38bb4040a9. The update must restore this structure with the appropriate timestamp for commit 87f3d3e198d3.

Required fix: Restore pseudo-version prefix
-	google.golang.org/genproto/googleapis/rpc 87f3d3e198d3 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-YYYYMMDDHHMMSS-87f3d3e198d3 // indirect

Replace YYYYMMDDHHMMSS with the actual commit timestamp for hash 87f3d3e198d3 from the google-genproto repository. Run go get -m google.golang.org/genproto/googleapis/rpc@87f3d3e198d3 to auto-resolve the correct pseudo-version.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 150, The go.mod file has an invalid pseudo-version entry for
the module google.golang.org/genproto/googleapis/rpc. The current entry uses
only a bare commit hash (87f3d3e198d3) instead of the required Go pseudo-version
format (v0.0.0-YYYYMMDDHHMMSS-commithash). To fix this, run the command go get
-m google.golang.org/genproto/googleapis/rpc@87f3d3e198d3 which will
automatically resolve and update the dependency to the correct pseudo-version
format with the proper timestamp for that commit hash.

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants