Skip to content

[ROSAENG-61225] fix: correct elevate command in service login prompt#967

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
joshbranham:fix-service-login-elevate-prompt
Jul 5, 2026
Merged

[ROSAENG-61225] fix: correct elevate command in service login prompt#967
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
joshbranham:fix-service-login-elevate-prompt

Conversation

@joshbranham

@joshbranham joshbranham commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

The suggested elevate command was missing the -n flag to prompt for an elevation reason, and used the plugin invocation form instead of the shipped binary name.

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Updated the generated command shown for listing manifestworks on hosted control plane clusters.
    • The command now uses the correct binary name, includes the required -n flag, and adjusts the subcommand after -- for more accurate copy/paste behavior.

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 4, 2026
@joshbranham joshbranham self-assigned this Jul 4, 2026
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 057bd4fb-2126-4ae0-a7b5-2f2ef6e02dbe

📥 Commits

Reviewing files that changed from the base of the PR and between c497229 and 976c06b.

📒 Files selected for processing (1)
  • cmd/ocm-backplane/login/login.go
✅ Files skipped from review due to trivial changes (1)
  • cmd/ocm-backplane/login/login.go

Walkthrough

Updates the hosted control plane login hint for listing manifestworks, changing the printed command to use ocm-backplane elevate -n and get manifestworks without the oc prefix.

Changes

Hosted control plane command hint

Layer / File(s) Summary
Update manifestwork command template
cmd/ocm-backplane/login/login.go
Changes the displayed manifestwork listing command to ocm-backplane elevate -n -- get manifestworks ... while preserving the namespace flag and label selector.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: correcting the elevate command in the service login prompt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@joshbranham joshbranham changed the title fix: correct elevate command in service login prompt [ROSAENG-61225] fix: correct elevate command in service login prompt Jul 4, 2026
@codecov-commenter

codecov-commenter commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.54%. Comparing base (47c277d) to head (976c06b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          82       82           
  Lines        6308     6308           
=======================================
  Hits         3441     3441           
  Misses       2417     2417           
  Partials      450      450           
Files with missing lines Coverage Δ
cmd/ocm-backplane/login/login.go 67.30% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cmd/ocm-backplane/login/login.go Outdated
@joshbranham joshbranham force-pushed the fix-service-login-elevate-prompt branch from c497229 to 976c06b Compare July 5, 2026 22:30
@xiaoyu74

xiaoyu74 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2026
@openshift-ci

openshift-ci Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2026
@openshift-ci

openshift-ci Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 7bb0e18 into openshift:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants