Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.36 into main - #412
Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.36 into main#412shiftstack-merge-bot[bot] wants to merge 2 commits into
Conversation
…l tags annotations (kubernetes#3154) * feat: add support for load balancer, listener, and pool tags annotations * feat: refactor load balancer tag handling to use SplitTrim for better parsing * feat: streamline load balancer listener tag management for improved consistency * feat: address PR kubernetes#3058 review feedback for LB tag annotations - Simplify mergeTags: drop unreachable nil check and redundant else - Collapse repeated SplitTrim guard blocks at all tag call sites - Correct annotation comments to comma-separated (not JSON) format - Add TestMergeTags and listener-tag cases to TestBuildListenerCreateOpt - Document load-balancer-tags, listener-tags and pool-tags annotations * Address feedback * Add withLBNameTag helper * Rename desiredTags completely * Change structure * Outdated comments * Fix mergeTags to treat empty/empty as no-op * Prevent duplicate tags * Also within annotations * Make sure tags are always populated * Sanitize user tags * Reserved service prefix * Introduce generic helpers --------- Co-authored-by: A10ss <la10ss@163.com> Co-authored-by: Alexander Stephan <alexander.stephan@sap.com>
openshift-ci
Bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
No description provided.