AGENT-1522: bump InternalReleaseImage to v1

[pawanpinjarkar]

• Chores
  • Updated module dependency configuration to use an alternate source for API dependencies.

  go get github.com/openshift/api
  go mod tidy
  go mod vendor
  

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

A replace directive is added to go.mod, redirecting the github.com/openshift/api module to a custom fork at github.com/pawanpinjarkar/api with a pinned version identifier.

Changes

Module replacement

Layer / File(s)	Summary
Module replacement directive go.mod	Add a replace directive that redirects github.com/openshift/api imports to github.com/pawanpinjarkar/api at a pinned version for all builds using this go.mod.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references bumping InternalReleaseImage to v1, but the actual change is a go.mod replace directive redirecting github.com/openshift/api to a fork, which doesn't match the stated objective.	Update the title to accurately reflect the change: something like 'Replace openshift/api with pawanpinjarkar/api fork' or clarify how this redirect supports the InternalReleaseImage bump.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR adds 184 new test files to the repository, but ZERO of them use Ginkgo testing framework. All test files use standard Go testing (via func Test... and t.Run()), so the Ginkgo test namin...
Test Structure And Quality	✅ Passed	PR #10620 changes only go.mod/go.sum (replace directive for openshift/api); no Ginkgo test code (It blocks) was modified, so the test-quality checks are not applicable.
Microshift Test Compatibility	✅ Passed	PR commit only updates go.mod (replace openshift/api -> pawanpinjarkar/api). Among changed non-vendor *_test.go files, none contain “ginkgo” or ginkgo/v2—no MicroShift-incompatible Ginkgo e2e tests...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Checked PR HEAD changed non-vendor _test.go/.go for any github.com/onsi/ginkgo or ginkgo. usage: none found, so no new SNO-incompatible multi-node Ginkgo e2e tests were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	PR 10620 only updates go.mod (replace github.com/openshift/api) and related go.sum/vendor API files; no installer manifests/operator/controller scheduling constraints were changed.
Ote Binary Stdout Contract	✅ Passed	PR only updates go.mod/go.sum (replace) and vendored openshift/api; representative changed vendor Go files contain no fmt/klog Print/Println/Printf, so no main/suite process-level stdout writes wer...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR diff vs origin/main includes only go.mod/go.sum, images/installer/Dockerfile.ci, and vendored api changes—no new or modified *_test.go/Ginkgo e2e specs, so no IPv4/Internet assumptions to flag.
No-Weak-Crypto	✅ Passed	PR appears limited to go.mod/go.sum replace + regenerated openshift/api vendored files; searches of updated vendor code found no md5/sha1/DES/RC4/3DES/Blowfish/ECB usages.
Container-Privileges	✅ Passed	PR #10620 modifies only go.mod and go.sum (no container/K8s manifest diffs). No instances of hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation: true found in related YAML under vendor...
No-Sensitive-Data-In-Logs	✅ Passed	PR #10620 changes only go.mod (adds a replace for github.com/openshift/api) and go.sum hashes; no application/logging code touched, so no sensitive data logging introduced.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[pawanpinjarkar]

/cc @andfasano @sadasu @bfournie

[pawanpinjarkar]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

[openshift-ci]

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[pawanpinjarkar]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

[openshift-ci]

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[pawanpinjarkar]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

[openshift-ci]

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[sadasu]

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/api#2880 openshift/client-go#383

[sadasu]

/retitle WIP: AGENT-1522: bump InternalReleaseImage to v1

The go.mod changes point to Pawan's openshift/api commit.

Also, @pawanpinjarkar while making the next update to the PR, please make sure to put just the go.mod changes in 1 commit and everything else in a 2nd commit.

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9993180-6646-11f1-9b81-8f288bc688c1-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d770f0-665d-11f1-9ef4-6c006290fce7-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d6df40-68cf-11f1-9a39-3d80b7114f29-0

[sadasu]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal/dev-scripts#1912

[openshift-ci]

@sadasu: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message.

unable to get pr from github for: openshift-metal/dev-scripts#1912: Get "http://ghproxy/repos/openshift-metal/dev-scripts/pulls/1912": failed to get installation id for org openshift-metal: the github app is not installed in organization openshift-metal

Please contact an administrator to resolve this issue.

[sadasu]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal3/dev-scripts#1912

[openshift-ci]

@sadasu: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pawanpinjarkar: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74c6ec20-6f4b-11f1-8dac-15939a93fec9-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a2112650-6f91-11f1-8669-f8ea88ed5f27-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3c9557a0-6fb5-11f1-8ba2-261bb323a340-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e18a3b20-6fc1-11f1-9a3e-8a562bf14c22-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c18dbbf0-6fd3-11f1-9c17-1160bc7a116c-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f9c4270-7066-11f1-987c-f057eabc019a-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3dc2ed00-7077-11f1-9373-ad56da90549d-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a024f190-70a0-11f1-90b5-4d52c88db967-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f474fbc0-70a8-11f1-8667-ca570bd96a96-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ac7a0210-70b3-11f1-9ff0-58eea2434dcb-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6110c6c0-7139-11f1-9201-ebaca0b9eef9-0

[openshift-ci]

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ad1f9e0-715b-11f1-9fd6-756025c45f8c-0

[bfournie]

Unit test is failing, perhaps needs a rebase?
```

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -22,5 +22,4 @@
        	            	   DeletionGracePeriodSeconds: (*int64)(<nil>),
        	            	-  Labels: (map[string]string) (len=2) {
        	            	-   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) "",
        	            	-   (string) (len=42) "machineconfiguration.openshift.io/osstream": (string) (len=7) "rhel-10"
        	            	+  Labels: (map[string]string) (len=1) {
        	            	+   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) ""
        	            	   },
        	Test:       	Test_GenerateMachines/usertags
    gcpmachines_test.go:112: 
        	Error Trace:	/go/src/github.com/openshift/installer/pkg/asset/machines/gcp/gcpmachines_test.go:112

[bfournie]

Looks like a unit test failure with OSStream expecting the rhel-10 label. I wonder why the vendor/github.com/openshift/api/features/features.go changed, as that may be what is causing this.

         	            	Diff:
           	            	--- Expected
           	            	+++ Actual
           	            	@@ -22,5 +22,4 @@
           	            	   DeletionGracePeriodSeconds: (*int64)(<nil>),
           	            	-  Labels: (map[string]string) (len=2) {
           	            	-   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) "",
           	            	-   (string) (len=42) "machineconfiguration.openshift.io/osstream": (string) (len=7) "rhel-10"
           	            	+  Labels: (map[string]string) (len=1) {
           	            	+   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) ""

[andfasano]

Yes

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andfasano]

/lgtm

[andfasano]

out of curiosity, what triggered this change?