Skip to content

CORS-4528: Remove OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK#10654

Open
sadasu wants to merge 2 commits into
openshift:mainfrom
sadasu:refactor-azure
Open

CORS-4528: Remove OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK#10654
sadasu wants to merge 2 commits into
openshift:mainfrom
sadasu:refactor-azure

Conversation

@sadasu

@sadasu sadasu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This allows to to use the pre-submit job for testing.
Additionally, refactored RHCOS image information extraction in a seperate method for easy maintainance.

@sadasu

sadasu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/test

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 51ca2107-f92e-4c18-b28a-db1d87814339

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from jhixson74 and rna-afk June 24, 2026 18:02
@sadasu

sadasu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview

1 similar comment
@sadasu

sadasu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu

sadasu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@sadasu

sadasu commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@sadasu sadasu changed the title DNM: WIP: Handle RHCOS image information extraction in a separate method Remove OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-dualstack-ipv6-primary-techpreview 2f99ce8 link false /test e2e-azure-ovn-dualstack-ipv6-primary-techpreview
ci/prow/e2e-azure-ovn 2f99ce8 link true /test e2e-azure-ovn
ci/prow/e2e-azure-ovn-shared-vpc 2f99ce8 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack 2f99ce8 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn 2f99ce8 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu

sadasu commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@sadasu sadasu changed the title Remove OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK CORS-4528: Remove OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK Jul 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@sadasu: This pull request references CORS-4528 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This allows to to use the pre-submit job for testing.
Additionally, refactored RHCOS image information extraction in a seperate method for easy maintainance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2026
@sadasu

sadasu commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/verified by e2e-azure-ovn-dualstack-ipv6-primary-techpreview

We are able to proceed with testing the feature using the pre-submit job.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sadasu: This PR has been marked as verified by e2e-azure-ovn-dualstack-ipv6-primary-techpreview.

Details

In response to this:

/verified by e2e-azure-ovn-dualstack-ipv6-primary-techpreview

We are able to proceed with testing the feature using the pre-submit job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants