Skip to content

Add npm ci step to backport skill#2222

Open
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:backport-skill-install-step
Open

Add npm ci step to backport skill#2222
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:backport-skill-install-step

Conversation

@kyoto

@kyoto kyoto commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Updated the backport workflow instructions to include a clean dependency reinstall (npm ci) after switching release branches.
    • Clarified the recommended execution order: lint fixes, internationalization, then build, reflecting the added install step.

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2026
@openshift-ci openshift-ci Bot requested review from joshuawilson and xrajesh July 14, 2026 11:23
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c6efd6d6-9df6-4c56-a40b-64f83a61e0b4

📥 Commits

Reviewing files that changed from the base of the PR and between b41996e and 866e41f.

📒 Files selected for processing (1)
  • .cursor/skills/backport/SKILL.md

📝 Walkthrough

Walkthrough

The backport workflow documentation now instructs contributors to run npm ci before linting, localization, and build commands, noting that release branches may require a clean lockfile-based dependency install.

Changes

Backport workflow

Layer / File(s) Summary
Refresh release-branch dependencies
.cursor/skills/backport/SKILL.md
Adds npm ci before the ordered npm run lint-fix, npm run i18n, and npm run build steps, with updated rationale and numbering.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: lgtm

Suggested reviewers: joshuawilson, xrajesh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change by adding an npm ci step to the backport skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.cursor/skills/backport/SKILL.md (1)

37-38: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Prefer npm ci for reproducible backport validation.

Because release branches may have different lockfiles, npm install can resolve newer versions allowed by semver ranges and rewrite package-lock.json. The repository’s dependency-refresh script already uses npm ci; use the same deterministic install here, or verify that every supported release branch intentionally permits lockfile updates.

Proposed change
-7. Run `npm install` — release branches have different dependency versions,
+7. Run `npm ci` — release branches have different dependency versions,
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.cursor/skills/backport/SKILL.md around lines 37 - 38, Update the backport
validation instructions in SKILL.md to use npm ci instead of npm install,
ensuring dependencies are installed reproducibly without resolving newer semver
versions or rewriting package-lock.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.cursor/skills/backport/SKILL.md:
- Around line 37-38: Update the backport validation instructions in SKILL.md to
use npm ci instead of npm install, ensuring dependencies are installed
reproducibly without resolving newer semver versions or rewriting
package-lock.json.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0b56857e-afc4-42e8-8fab-a594153b511a

📥 Commits

Reviewing files that changed from the base of the PR and between f2659ab and b41996e.

📒 Files selected for processing (1)
  • .cursor/skills/backport/SKILL.md

@kyoto kyoto force-pushed the backport-skill-install-step branch from b41996e to 7696055 Compare July 14, 2026 11:30
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2026
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@kyoto kyoto changed the title Add npm install step to backport skill Add npm ci step to backport skill Jul 14, 2026
@kyoto kyoto force-pushed the backport-skill-install-step branch from 7696055 to 866e41f Compare July 14, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant