Skip to content

PF5: Remove generic tool call error alert message#2223

Open
kyoto wants to merge 1 commit into
openshift:pattern-fly-5from
kyoto:pf5-remove-tool-error-alert
Open

PF5: Remove generic tool call error alert message#2223
kyoto wants to merge 1 commit into
openshift:pattern-fly-5from
kyoto:pf5-remove-tool-error-alert

Conversation

@kyoto

@kyoto kyoto commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Improved tool error modal behavior by removing the redundant unexpected-error alert.
    • Tool error details now display the relevant status and error information without incorrectly showing rejection messaging.
  • Tests

    • Added coverage for streamed responses containing tool errors to help ensure the modal presents accurate information.

@kyoto kyoto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2026
@openshift-ci openshift-ci Bot requested review from JoaoFula and syedriko July 14, 2026 11:32
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ddc08dd0-8358-4fd2-b45b-d0553489ccdb

📥 Commits

Reviewing files that changed from the base of the PR and between 98d2db5 and f7a436d.

📒 Files selected for processing (4)
  • locales/en/plugin__lightspeed-console-plugin.json
  • src/components/ResponseToolModal.tsx
  • tests/support/fixtures.ts
  • tests/tests/lightspeed.spec.ts
💤 Files with no reviewable changes (2)
  • src/components/ResponseToolModal.tsx
  • locales/en/plugin__lightspeed-console-plugin.json

📝 Walkthrough

Walkthrough

The tool error modal no longer displays a generic error alert. English translations for that alert were removed, and a streamed tool-error fixture with browser coverage was added.

Changes

Tool error modal

Layer / File(s) Summary
Remove generic error alert
src/components/ResponseToolModal.tsx, locales/en/plugin__lightspeed-console-plugin.json
The modal skips the generic error alert for tool-call errors, and its two English translation entries were removed.
Cover streamed tool errors
tests/support/fixtures.ts, tests/tests/lightspeed.spec.ts
A failing SSE fixture and serial test verify tool status, output, error text, and the absence of “Tool call rejected”.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: joshuawilson, syedriko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the generic tool call error alert message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant