OCPBUGS-95281: Synchronize From Upstream Repositories#762
Open
openshift-bot wants to merge 108 commits into
Open
OCPBUGS-95281: Synchronize From Upstream Repositories#762openshift-bot wants to merge 108 commits into
openshift-bot wants to merge 108 commits into
Conversation
…back (#2791) - Upgrade go.opentelemetry.io/otel/exporters/otlp/otlptrace, otlptracegrpc, and otel/sdk from v1.43.0 to v1.44.0 to match otel, otel/metric, and otel/trace already at v1.44.0 - Move E2E_TIMEOUT fallback from target-specific ?= into the e2e-run-% recipe via $(or $(E2E_TIMEOUT),20m) so the 20m default is explicit and the 25m override from test-experimental-e2e is unambiguous Signed-off-by: Todd Short <tshort@redhat.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-bot
added
tide/merge-method-merge
WalkthroughUpdates the e2e Makefile timeout handling and demo regeneration flow, replaces demo embeds in docs with local players/SVGs, removes legacy demo assets, and refreshes indirect module versions across the root and tooling modules. ChangesDemo automation and docs
Dependency refresh
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 3 warnings)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.21.6 to 0.21.7. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Commits](google/go-containerregistry@v0.21.6...v0.21.7) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-version: 0.21.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
openshift-bot
force-pushed
the
synchronize-upstream
branch
from
533d541 to
8795f00
Compare
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
/verified by ci |
openshift-ci-robot
added
the
verified
|
@perdasilva: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Convert terminal demos from standalone shell scripts recorded via asciinema to Godog BDD scenarios that generate asciicast v2 files programmatically. This makes demos into verified tests that can never silently break while producing terminal recordings. The recording infrastructure captures kubectl commands and their stdout/stderr with real execution timing during @demo-tagged scenario execution. Per-step dedup handles polling transparently so only successful results appear in the recording. Step text is emitted as comments and commands are colored for readability. Demo scenarios: - ClusterCatalog Quickstart: queries the operatorhubio catalog API - SingleNamespace Install Mode: installs mariadb-operator with a separate watch namespace, verifies rolebindings - OwnNamespace Install Mode: installs mariadb-operator with watch namespace equal to install namespace - Webhook Support: installs telegraf-operator, verifies mutating webhook injects sidecar container into test pod Not converted (no matching demo scenarios): - Synthetic User Permissions: feature gate disabled in experimental - Helm Chart Support: blocked by OCPBUGS-95281 The update-demos Makefile target now builds OLM from source using the experimental e2e infrastructure, deploys with all feature gates and operatorhubio catalog, runs demo scenarios, converts recordings to SVG via svg-term-cli, and tears down the cluster. Demo recordings are embedded in docs via the mkdocs-asciinema-player plugin and served from GitHub Pages, removing the dependency on asciinema.org for hosting recordings. Demo scenarios are excluded from regular e2e test runs via ~@demo filter. CI workflow (update-demos.yaml): - On PR: generates demos, uploads asciicast and SVG files as job artifacts - On merge to main: generates demos, deploys docs with updated recordings via make deploy-docs Old demo shell scripts, the asciinema generate-asciidemo.sh wrapper, and hack/demo/ resource files have been removed. Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.38.0 to 0.55.0. - [Commits](golang/net@v0.38.0...v0.55.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.55.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/sigstore/fulcio](https://github.com/sigstore/fulcio) from 1.8.5 to 1.8.6. - [Release notes](https://github.com/sigstore/fulcio/releases) - [Changelog](https://github.com/sigstore/fulcio/blob/main/CHANGELOG.md) - [Commits](sigstore/fulcio@v1.8.5...v1.8.6) --- updated-dependencies: - dependency-name: github.com/sigstore/fulcio dependency-version: 1.8.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dtfranz <dfranz@redhat.com> UPSTREAM: <carry>: Update generate-manifests to handle new directory The `default` directory was renamed `base`. Signed-off-by: Todd Short <todd.short@me.com> The `base` directory was moved to `base\operator-controller`. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Drop commitchecker Signed-off-by: Alexander Greene <greene.al1991@gmail.com> UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/4022cd290f00a44d667dda03f2d78d84a488c7ed/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: update owners * Remove alumni from owners * Add m1kola to approvers Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com> UPSTREAM: <carry>: Add pointer to tooling README UPSTREAM: <carry>: Disable Validating Admission Policy APIs downstream Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com> UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.16 Reconciling with https://github.com/openshift/ocp-build-data/tree/6250d54c4686a708ca5985afb73080e8ca9a1f7f/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: Enable Validating Admission Policy APIs downstream * This reverts commit 3f079c4. * Includes Validating Admission Policy manifests Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com> UPSTREAM: <carry>: manifests: set required-scc for openshift workloads UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.17 Reconciling with https://github.com/openshift/ocp-build-data/tree/4c1326094222f9209876f06833179a1b9178faf7/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: add everettraven to approvers+reviewers Signed-off-by: everettraven <everettraven@gmail.com> UPSTREAM: <carry>: add openshift kustomize overlay to enable TLS communication with catalogd. Configure the CA certs using the configmap injection method via service-ca-operator Signed-off-by: everettraven <everettraven@gmail.com> UPSTREAM: <carry>: Add tmshort to approvers Also `s/runtime/framework/g` in the DOWNSTREAM_OWNERS Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/dd68246f3237db5db458127566fc7b05b55e1660/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: Properly copy and call kustomize Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: manifests: add hostPath mount for /etc/containers Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Add test-e2e target for downstream Makefile to be run by openshift/release. Signed-off-by: dtfranz <dfranz@redhat.com> UPSTREAM: <carry>: Add downstream verify makefile target Signed-off-by: dtfranz <dfranz@redhat.com> UPSTREAM: <carry>: openshift: template log verbosity to be managed by cluster-olm-operator Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Add global-pull-secret flag Pass global-pull-secret to the manager container. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com> UPSTREAM: <carry>: Update openshift CAs to operator-controller The /run/secrets/kubernetes.io/serviceaccount/ directory is projected into the pod and contains the following CA certificates: * configmap/kube-root-ca.crt as ca.crt * configmap/openshift-service-ca.crt as service-ca.crt Update the --ca-certs-dir argument to reference the directory. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Add HowTo for origin tests Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Add e2e registry Dockerfile Signed-off-by: dtfranz <dfranz@redhat.com> UPSTREAM: <carry>: add nodeSelector and tolerations to operator-controller deployment via kustomize patch Signed-off-by: everettraven <everettraven@gmail.com> UPSTREAM: <carry>: namespace: use privileged PSA for audit and warn levels Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Enable downstream e2e Signed-off-by: dtfranz <dfranz@redhat.com> UPSTREAM: <carry>: Remove m1kola from owners Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com> UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.19 Reconciling with https://github.com/openshift/ocp-build-data/tree/a39508c86497b4e5e463d7b2c78e51e577be9e7d/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: generate and mount service-ca server cert Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Add support for proxy trustedCAs Just map the list of trusted ca certs into the deployment Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Fix error to build the image Copy correct (new) executable name for operator-controller Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Fix make verify for mac os envs Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Move operator-controller openshift files to its own dir UPSTREAM: <carry>: Upgrade OCP images from 4.18 to 4.19 UPSTREAM: <carry>: Add Openshift's catalogd manifests - Move to openshift/catalogd the specific manifest under: https://github.com/openshift/operator-framework-catalogd/tree/main/openshift - Add call to generate catalogd manifest to 'make manifest'. Make verify test is now done for catalogd and operator-controller Openshift's manifests UPSTREAM: <carry>: resolve issue with pre-mature mounting of trusted CA configmap Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Add /etc/docker to the operator-controller and catalogd deployments This allows for use of the any image.config.openshift.io trusted CAs Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: fixup catalogd.Dockerfile paths Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Resolve issue with pre-mature mounting of service CA configmap Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: use projected volume for CAs to avoid subPath limitations Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Revert "UPSTREAM: <carry>: use projected volume for CAs to avoid subPath limitations" This reverts commit 548caa4. UPSTREAM: <carry>: use projected volume for CAs to avoid subPath limitations Signed-off-by: Joe Lanford <joe.lanford@gmail.com> UPSTREAM: <carry>: Remove vet from openshift verify The `vet` target was removed upstream. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Skip another upstream test Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Cleanup openshift/Makefile by removing no longer required comments regards catalogd e2e tests UPSTREAM: <carry>: Enable OCP metrics collection by default Enables OCP to collect Prometheus metrics for both catalogd and operator-controller by default. This is accomplished via ServiceMonitor CRs which are now created for both projects. UPSTREAM: <carry>: Fix catalogd.Dockerfile to use new paths The root catalogd directory has been removed Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Update DOWNSTREAM_OWNERS_ALIASES Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Add openshift node selector annotation Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com> (cherry picked from commit 9b4a113) UPSTREAM: <carry>: Add caalogd-cas-dir option to op-con Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: set the SElinux type Signed-off-by: Jian Zhang <jiazha@redhat.com> UPSTREAM: <carry>: Add initial stack to run tests to validate the catalogs UPSTREAM: <carry>: Add vendor files for the catalog-sync tests UPSTREAM: <carry>: Bump catalog versions to 4.19 Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: revert "Bump catalog versions to 4.19" This reverts commit a98980b. UPSTREAM: <carry>: Update HOWTO-origin-tests techpreview is no longer a required option. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [DefaultCatalogTests]: Allow to pass auth path for docker credentials" UPSTREAM: <carry>: fix: set NoLchown=true to allow image unpack on OCPci UPSTREAM: <carry>: [DefaultCatalogTests]: Moving parse of ENVVAR to the caller (follow-up 345) UPSTREAM: <carry>: [Default Catalog]: Create tmp dir to extract layers with right permissions to avoid issues scenarios UPSTREAM: <carry>: [Default Catalog](cleanp) Remove hack directory which is not used UPSTREAM: <carry>: Change code implementation to extract layers in OCP env UPSTREAM: <carry>: Add vendor files for change in the extract code implementation UPSTREAM: <carry>: [Default Catalog Tests]: Final cleanups and enhancements of initial implementation UPSTREAM: <carry>: SELinux type for operator-controller Signed-off-by: Jian Zhang <jiazha@redhat.com> UPSTREAM: <carry>: Bump catalog versions to 4.19 Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [Default Catalog Consistency Test] (feat) add check for executable files in filesystem Checks if given paths exist and point to executable files or valid symlinks. UPSTREAM: <carry>: [Default Catalog Consistency Test]: fix junit output format to allow generate xml UPSTREAM: <carry>: [Default Catalog Consistency Test] (feat) add check to validate multi-arch support UPSTREAM: <carry>: [Default Catalog Consistency Test]: Enable CatalogChecks UPSTREAM: <carry>: [Default Catalog Consistency Test]: Rename Tests suite and small cleanups UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.20 Reconciling with https://github.com/openshift/ocp-build-data/tree/dfb5c7d531490cfdc61a3b88bc533702b9624997/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: Updating ose-olm-catalogd-container image to be consistent with ART for 4.20 Reconciling with https://github.com/openshift/ocp-build-data/tree/dfb5c7d531490cfdc61a3b88bc533702b9624997/images/ose-olm-catalogd.yml UPSTREAM: <carry>: Update e2e registry to use 1.24/4.20 Update the e2e registry Dockerfile to use golang 1.24/OCP 4.20 Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [Catalog Default Tests]: Upgrade go version to 1.24.3, dependencies and fix new lint issue UPSTREAM: <carry>: Add structure to allow move the orgin tests using OTE This commit introduces a binary and supporting structure to enable the execution of OpenShift origin (olmv1) tests using the Open Test Environment (OTE). It lays the groundwork for moving origin test in openshift/origin to be executed from this repository using OTE. UPSTREAM: <carry>: Add support for experimental manifests Update the openshift kustomize configuration for both operator-controller and catalogd. Update the manifest generation scripts to put the core generation code into a function (ignore-whitespace will help with the review), so that it can be called twice; once for standard, and once for experimental. Move around some of the kustomization directives to * Create a patch kustomization (Component) file and move the patch directives from olmv1-ns there. This allows it to be referenced from a different directory. * Add a kustomization file for tusted-ca. This allows it to be referenced from a different directory. * Move the setting of the namePrefix for operator-controller; this makes the generation compatible with upstream feature components. * Define experimental kustomization files that reference existing components. * Reference the correct CRDs (standard or experimental). * Add references to upstream feature components into the experimental manifests. This *will* add `--feature-gates` options from the upstream feature components to the experimental manifests. The cluster-olm-operator will strip those arguments from the deployments before adding the enabled feature gates. Update the Dockerfiles to include the experimental manifests and a copy script (`cp-manifests`) into the image containers. The complexity of having multiple sets of manifests mean that the simple initContainer copy mechanism found in cluster-olm-operator is no longer sufficient. This attempts to keep backwards compatibility with older versions of cluster-olm-operator, specifically by keeping the original (standard) manifests in the original location, and adding the experimental manifests in a new directory. The new `cp-manifests` script is used by newer versions of cluster-olm-operator. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [OTE] - chore: follow up openshift#383 – remove unreachable target call UPSTREAM: <carry>: Remove build of test image registry Upstream now uses a different image Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Add test-experimental-e2e target to openshift Makefile This adds a test-experimental-e2e target to allow the CI to run the experimental e2e test. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [OTE]: Add binary in the operator controller image to allow proper integration with OCP tests UPSTREAM: <carry>: Fix experimental manifest copying The standard manifest was being copied rather than the experimental manifest. This meant that the expected feature-flags are not present. This is failing now that we are doing a check for those feature-flags. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Update manifest generation for upstream rbac/webhooks Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [OTE] - Add tracking mechanism UPSTREAM: <carry>: Update OTE dep to get fix UPSTREAM: <carry>: [OTE] Add Readme UPSTREAM: <carry>: set GIT_COMMIT env from SOURCE_GIT_COMMIT in Dockerfiles for operator-controller and catalogd Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> UPSTREAM: <carry>: add openshift specific build target to pass commit info downstream Signed-off-by: Ankita Thomas <ankithom@redhat.com> UPSTREAM: <carry>: add source commit into binaries when linking - Removes extra GIT_COMMIT set - fixup Dockerfiles after rebase - consider "" unset so build-info can fill commit/date - double quote go flags & honor GIT_COMMIT if set - improve robustness of build-info parsing - Trim whitespace on all version fields - isUnset and valueOrUnknown now call strings.TrimSpace - Avoid clobbering values injected via ldflags - set repoState from build-info only when repoState is still unset - set version from build-info only when unset and build-info value is non-empty UPSTREAM: <carry>: OTE add first test from openshift/origin olmv1.go UPSTREAM: <carry>: Migrate tasks from openshift/origin olm v1.go file which are remaining This commit moves the final OLMv1 tests from openshift/origin/test/extended/olm/olmv1.go to their proper location in this repository. This migration is part of a larger effort to streamline development by co-locating tests with the component they validate. This will reduce CI overhead and allow for faster, more atomic changes. Assisted-by: Gemini UPSTREAM: <carry>: OTE - How to test locally with OCP instances UPSTREAM: <carry>: [OTE] Refac: refac helper and olmv1 test to create namespace instead to use pre-existent UPSTREAM: <carry>: [OTE] add webhook tests Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini UPSTREAM: <carry>: OTE: rewrite the upgrade incompatible operator test This test replaces the existing upgrade incompatible test. The main change is that operator and catalog bundles are created on-the-fly to support OCP 4.20. This means we are no longer dependent on public operators for this test. This creates new bundles in the OCP ImageRegistry, this requires using a number of OCP APIs, including using a raw API URL to invoke the build. This is done by invoking an external k8s client (either `oc` or `kubectl`), and passing it a tarball of the bundle to be created. So, it can't be done by the golang k8sClient normally available (i.e. the create input is a tarball not a YAML file). This introduces the use of go-bindata to store the bundle contents. It also pulls in openshift mage, buld and operator APIs. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Handle service-ca cert availability/rotation There is problem when the service-ca certificate is not available at pod start. This is an issue because the SystemCertPool is created from SSL_CERT_DIR, which may include the empty service-ca. The SystemCertPool is never regenerated during the lifetime of the program execution, so it will never get updated when the service-ca is filled. Thus, we need to use --pull-cas-dir to reference the CAs that we want to use. This will also allow OLMv1 to reload the service-ca when it is reloaded (after 2 years, mind you). Removing the SSL_CERT_DIR setting, and adding the --pull-cas-dir flag ought to be equivalent to what we have now (i.e. SSL_CERT_DIR and no --pull-cas-dir), except that rotation will be handled better. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [OTE] add webhook tests Revert "UPSTREAM: <carry>: [OTE] add webhook tests" This reverts commit 9963614. UPSTREAM: <carry>: Upgrade OCP Catalog images from 4.19 to 4.20 UPSTREAM: <carry>: Remove bindata generation from build Using go-bindata is causing problems with ART builds. This removes the use of go-bindata from the builds. This will subsequently require that users MANUALLY run the `bindata` target to refresh the bindata, or use the `build-update` target. This is a quickfix to put out the fire. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: [OTE] Add webhook tests - Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini UPSTREAM: <carry>: OTE add logs and dumps for olmv1 test and fix helper for clusterextensions UPSTREAM: <carry>: [OTE] Migrate preflight checks from openshift/origin Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies. The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs. Assisted-by: Gemini UPSTREAM: <carry>: [OTE] Add webhook to validate openshift-service-ca certificate rotation This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini UPSTREAM: <carry>: Adds ResourceVersion checks to the tls secret deletion test, mirroring the logic used in the certificate rotation test. This makes the test more robust by ensuring a new secret is created, not just that an existing one is still present. UPSTREAM: <carry>: [OTE] - Readme:Add info to help use payload-aggregate with new tests UPSTREAM: <carry>: remove obsolete owners Signed-off-by: grokspawn <jordan@nimblewidget.com> UPSTREAM: <carry>: [OTE] add catalog tests from openshift/origin This commit migrates the olmv1_catalog set of tests from openshift/origin to OTE as part the broad effort to migrate all tests. Assisted-by: Gemini UPSTREAM: <carry>: Migrate single/own namespace tests This commit migrates the OLMv1 single and own namespace watch mode tests from openshift/origin/test/extended/olm/olmv1-singleownnamespace.go to this repository. This is part of the effort to move component-specific tests into their respective downstream locations. Assisted-by: Gemini UPSTREAM: <carry>: Adds ResourceVersion checks to the tls secret deletion test, mirroring the logic used in the certificate rotation test. This makes the test more robust by ensuring a new secret is created, not just that an existing one is still present. This reverts commit 0bb1953. UPSTREAM: <carry>: [OTE] Add webhook to validate openshift-service-ca certificate rotation This reverts commit e9e3220. UPSTREAM: <carry>: Ensure unique name for bad-catalog tests UPSTREAM: <carry>: Revert "Handle service-ca cert availability/rotation" This reverts commit 9cc13d8. UPSTREAM: <carry>: grant QE approver permission for OTE UPSTREAM: <carry>: Update webhook ote tests to use latest webhook-operator Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> UPSTREAM: <carry>: update operator-controller to v1.5.1 UPSTREAM: <carry>: configure watchnamespace using spec.config for OTE tests UPSTREAM: <carry>: add jiazha to approvers UPSTREAM: <carry>: Create combined manifests for comparison Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Use Helm charts for openshift manifests Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: add support for tests-private cases and add the case UPSTREAM: <carry>: Fix cp-manifests copying of helm charts The method used to copy the helm charts is including an extra `helm` directory in the destination path, that is making the cluster-olm-operator code just a bit more complicated than it needs to be. This fixes the copy location. Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Remove kustomize manifests from images and repo Now that helm manifests are being used to dynamically generate the manifests, the pre-generated manifests are no longer needed. So, we can remove them from the repo and the images. However, because we still want to verify the manifests are "good", we are still creating a "single-file" version of the manifests for verification purposes, and to allow us to see what changes are happening to the manifests (from upstream and/or downstream sources). Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Add pedjak and trgeiger as reviewers UPSTREAM: <carry>: migrate more cases from tests-private and enhance suites with filters UPSTREAM: <carry>: Updating ose-olm-operator-controller-container image to be consistent with ART for 4.21 Reconciling with https://github.com/openshift/ocp-build-data/tree/4fbe3fab45239dc4be6f5d9d98a0bf36e0274ec9/images/ose-olm-operator-controller.yml UPSTREAM: <carry>: Updating ose-olm-catalogd-container image to be consistent with ART for 4.21 Reconciling with https://github.com/openshift/ocp-build-data/tree/4fbe3fab45239dc4be6f5d9d98a0bf36e0274ec9/images/ose-olm-catalogd.yml UPSTREAM: <carry>: OTE: Enable disconnected environment and build test operator controller image Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> UPSTREAM: <carry>: for incompatible test add func to wait builder and deployer SA creation by OCP controller UPSTREAM: <carry>: Fix VERSION replacement in catalog bindata Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: check kubeconfig only run-test and run-suite UPSTREAM: <carry>: Clean up cp-manifests There is no longer a need to copy conditionally Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: Update does-not-exist and simple install to work in a disconnected environment Signed-off-by: Todd Short <todd.short@me.com> UPSTREAM: <carry>: support webhook case in disconnected UPSTREAM: <carry>: Consolidate build API This consolidates the in-cluster building of a bundle and catalog. The catalog and bundle bindata are inputs, along with a set of replacements so that catalog and bundle templates can be used to create the images. This can be done in the BeforeEach() for a set of tests that use the same data. Signed-off-by: Todd Short <todd.short@me.com>
…images from openshift/catalogd/manifests.yaml
Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Todd Short <todd.short@me.com>
…to run outside of OCP
…ffinity for HA topology Rolling updates in HighlyAvailable clusters leave catalogd and operator-controller unavailable when the only running pod is evicted before its replacement is ready. Fix by defaulting replicas=1 and PDB disabled in the static Helm values (safe for SNO/External topologies, passes the SNO conformance test that asserts exactly one replica in SingleReplica topology mode). Add pod anti-affinity to prefer scheduling replicas on different nodes. cluster-olm-operator detects the cluster's ControlPlaneTopology at startup and overrides these values to replicas=2 and PDB enabled when a HighlyAvailable topology is detected, then re-renders the manifests before starting controllers. When a topology change is observed at runtime (exceedingly rare), the operator exits so its deployment controller restarts it, triggering a fresh Helm render with the correct values for the new topology. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
…etween both-watch-modes scenarios The both-watch-modes test loops over two scenarios (singlens, ownns) inside a single It block and was blocking on full namespace deletion between them. This caused flaky 300s timeouts on GCP techpreview clusters where master nodes run at 94-99% CPU, which starves the namespace controller and makes namespace termination arbitrarily slow. The wait was not guarding anything real: - EnsureCleanupClusterExtension already ensures the CE and CRD are gone; since CE deletion uses ForegroundPropagation, the ClusterObjectSet teardown must complete before the CE disappears, meaning all managed resources (Deployments, Services, etc.) are already deleted at that point. - The singleown bundle installs no ValidatingWebhookConfiguration or MutatingWebhookConfiguration, so there is no webhook admission risk. - Each scenario generates unique namespace names and CRD group suffixes via rand.String(4), so a terminating namespace from scenario 1 cannot collide with or interfere with scenario 2's resources. Trigger both namespace deletions and proceed without waiting. The DeferCleanup registrations that already exist will handle any residual cleanup after the spec exits. Fixes: OCPBUGS-84943 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
- Replace broken test-experimental-e2e target (test/experimental-e2e no longer exists) with /bin/true so triggered jobs always succeed - Pass -timeout=60m to go test; the previous invocation relied on Go's 10m default which is too short for BoxcutterRuntime clusters - Set E2E_STEP_TIMEOUT=15m; BoxcutterRuntime applies resources through sequential phases (CRD must reach Established before the deploy phase starts), making installations slower than the upstream 5m default - Skip ~@CatalogdHA scenarios (require multiple catalogd replicas not present in standard topology) - Skip ~@ProgressDeadline scenarios (require progressDeadlineMinutes < 10 but the OpenShift CRD enforces a minimum of 10) - Skip ~@httpproxy scenarios (too disruptive to cluster networking) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Todd Short <tshort@redhat.com>
The e2e-test-registry image is no longer built by CI after openshift/release#78581 removed it from the CI config. The dynamic per-scenario catalog system replaced the pre-built registry image, making this Dockerfile dead code.
It's no longer bring used. Signed-off-by: Todd Short <tshort@redhat.com>
Adds a new test that verifies cluster-olm-operator correctly configures operator-controller and catalogd deployments based on the cluster's control plane topology: - HA topologies (HighlyAvailable, HighlyAvailableArbiter, DualReplica): replicas=2 with a PodDisruptionBudget present - Non-HA topologies (SingleReplica/SNO, External): replicas=1, no PDB Also registers policyv1 in the test scheme to support PDB list queries. Assisted-by: claude Signed-off-by: Todd Short <tshort@redhat.com>
… builders Signed-off-by: Todd Short <tshort@redhat.com>
…ge to be consistent with ART for 5.0 Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/7691ed4dc0b6585b358f9e73fb736ace9a48a286/images/ose-olm-operator-controller.yml
Set catalog image tags to v5.0 for the 4.23/5.0 release. Dynamically discover an installable package from the serving catalogs instead of hardcoding quay-operator v3.13.10, preferring quay-operator, cluster-logging, serverless-operator, logic-operator in that order then alling back to the first available package. Signed-off-by: Todd Short <tshort@redhat.com>
openshift-bot
changed the title
openshift-bot
force-pushed
the
synchronize-upstream
branch
from
8795f00 to
f3c0f3a
Compare
openshift-ci-robot
removed
the
verified
Contributor
|
New changes are detected. LGTM label has been removed. |
openshift-ci-robot
added
the
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-95281, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Makefile (2)
724-725: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueConsider pinning the
node:alpineimage tag.Floating
node:alpinetag can silently change Node.js versions between runs, causing non-reproducible demo generation. Since this is dev/demo tooling only, this is a minor nit.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 724 - 725, The demo-generation command in the Makefile uses the floating node:alpine image tag, which can change behavior between runs. Update the docker run invocation in this demo tooling step to use a pinned Node image tag instead of node:alpine, so the svg-term-cli conversion stays reproducible across runs.
709-716: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueHardcoded 30m timeout, inconsistent with
E2E_TIMEOUTfallback pattern used elsewhere.
e2e-run-%uses$(or $(E2E_TIMEOUT),20m)for its fallback;demo-e2einstead hardcodes-timeout 30m, so overridingE2E_TIMEOUTfor a demo run isn't possible.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 709 - 716, The demo-e2e target hardcodes the Go test timeout instead of using the same configurable fallback pattern as e2e-run-%, so make demo-e2e respect E2E_TIMEOUT with a default value rather than always passing 30m. Update the go test invocation in the demo-e2e recipe to use the existing E2E_TIMEOUT variable pattern, and keep the change localized to the demo-e2e target so the timeout remains overridable without affecting the rest of the Makefile.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 718-726: The demo-svg recipe currently iterates over an unquoted
*.cast glob, so when no recordings exist it passes a literal path into docker
and fails confusingly. Update the demo-svg target to use bash-friendly glob
handling in the recipe (consistent with the existing bash-only [[ ]] usage) by
enabling a no-match-safe pattern or explicitly checking for matching files
before the loop, and keep the existing demo-svg command flow and symbols like
demo-svg, DEMO_OUTPUT_DIR, and the for cast loop intact.
---
Nitpick comments:
In `@Makefile`:
- Around line 724-725: The demo-generation command in the Makefile uses the
floating node:alpine image tag, which can change behavior between runs. Update
the docker run invocation in this demo tooling step to use a pinned Node image
tag instead of node:alpine, so the svg-term-cli conversion stays reproducible
across runs.
- Around line 709-716: The demo-e2e target hardcodes the Go test timeout instead
of using the same configurable fallback pattern as e2e-run-%, so make demo-e2e
respect E2E_TIMEOUT with a default value rather than always passing 30m. Update
the go test invocation in the demo-e2e recipe to use the existing E2E_TIMEOUT
variable pattern, and keep the change localized to the demo-e2e target so the
timeout remains overridable without affecting the rest of the Makefile.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e33e6ee5-3aa2-4c37-9d70-fcfd25c16a5c
⛔ Files ignored due to path filters (251)
go.sumis excluded by!**/*.sumhack/tools/test-profiling/go.sumis excluded by!**/*.sumhack/tools/test-profiling/vendor/golang.org/x/net/html/escape.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/iter.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/node.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/nodetype_string.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/parse.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/render.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/html/token.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/README.mdis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_conn_pool.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_priority_go126.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/client_priority_go127.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/clientconn.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go124.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go125.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_go126.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/config_pre_go124.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/frame.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/gotrack.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/http2.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/server_wrap.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/timer.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/transport_wrap.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_common.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_random.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/http2/writesched_roundrobin.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/go118.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/idna.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/idna9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/pre_go118.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/punycode.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/trie12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/idna/trie13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/httpcommon/request.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/httpsfv/httpsfv.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/internal/socks/socks.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/net/websocket/hybi.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/pwd_go15_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/pwd_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/plan9/syscall_plan9.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/fdset.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ioctl_signed.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ioctl_unsigned.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/mkall.shis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/readv_unix.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_darwin.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_openbsd.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_solaris.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/syscall_unix.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.sis excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/aliases.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/dll_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/security_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/types_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/term/term_windows.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/term/terminal.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/core.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables13.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/bidi/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/forminfo.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables10.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables11.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables12.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables15.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables17.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/golang.org/x/text/unicode/norm/tables9.0.0.gois excluded by!**/vendor/**hack/tools/test-profiling/vendor/modules.txtis excluded by!**/vendor/**openshift/tests-extension/go.sumis excluded by!**/*.sumopenshift/tests-extension/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform/attribute.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/client.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/options.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/host_id_exec.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/os_windows.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!**/vendor/**openshift/tests-extension/vendor/go.opentelemetry.io/otel/semconv/v1.41.0/otelconv/metric.gois excluded by!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift/tests-extension/vendor/modules.txtis excluded by!**/vendor/**vendor/github.com/google/go-containerregistry/internal/gzip/zip.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/internal/limit/limit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/name/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/name/repository.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/registry/blobs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/registry/blobs_disk.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/layout/blob.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/mutate/mutate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/catalog.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/fetcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/referrers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/bearer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/tarball/image.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/google/go-containerregistry/pkg/v1/tarball/write.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sigstore/fulcio/pkg/certificate/extensions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sigstore/protobuf-specs/gen/pb-go/common/v1/sigstore_common.pb.gois excluded by!**/*.pb.go,!**/gen/**,!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform/attribute.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/client.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/options.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/builtin.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/container.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/env.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/host_id_exec.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_unix.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/os_windows.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/resource/process.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/batch_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/batch_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/simple_span_processor.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/internal/observ/tracer.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/provider.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/sampling.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/trace/span_limits.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/sdk/version.gois excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/otel/semconv/v1.41.0/otelconv/metric.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/annotations/client.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/genproto/googleapis/api/expr/v1alpha1/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (40)
.gitignoreMakefileREADME.mddocs/draft/howto/enable-webhook-support.mddocs/draft/howto/single-ownnamespace-install.mdgo.modhack/demo/catalogd-demo-script.shhack/demo/catalogd-metas-demo-script.shhack/demo/generate-asciidemo.shhack/demo/graphql-demo-script.shhack/demo/graphql-demo-server/main.gohack/demo/gzip-demo-script.shhack/demo/own-namespace-demo-script.shhack/demo/resources/own-namespace-demo.yamlhack/demo/resources/single-namespace-demo.yamlhack/demo/resources/synthetic-user-perms/argocd-clusterextension.yamlhack/demo/resources/synthetic-user-perms/cegroup-admin-binding.yamlhack/demo/resources/webhook-provider-certmanager/mutating-webhook-test.yamlhack/demo/resources/webhook-provider-certmanager/validating-webhook-test.yamlhack/demo/resources/webhook-provider-certmanager/webhook-operator-catalog.yamlhack/demo/resources/webhook-provider-certmanager/webhook-operator-extension.yamlhack/demo/single-namespace-demo-script.shhack/demo/synthetic-user-cluster-admin-demo-script.shhack/demo/webhook-provider-certmanager-demo-script.shhack/tools/test-profiling/go.modmkdocs.ymlopenshift/tests-extension/go.modrequirements.txtscripts/install.tpl.shtest/e2e/features/demos.featuretest/e2e/features_test.gotest/e2e/steps/asciicast_hooks.gotest/e2e/steps/asciicast_recorder.gotest/e2e/steps/demo_steps.gotest/e2e/steps/ha_steps.gotest/e2e/steps/hooks.gotest/e2e/steps/proxy_steps.gotest/e2e/steps/steps.gotest/e2e/steps/tls_steps.gotest/e2e/steps/upgrade_steps.go
💤 Files with no reviewable changes (18)
- hack/demo/resources/webhook-provider-certmanager/validating-webhook-test.yaml
- hack/demo/resources/single-namespace-demo.yaml
- hack/demo/resources/synthetic-user-perms/cegroup-admin-binding.yaml
- hack/demo/webhook-provider-certmanager-demo-script.sh
- hack/demo/catalogd-demo-script.sh
- hack/demo/resources/webhook-provider-certmanager/webhook-operator-catalog.yaml
- hack/demo/graphql-demo-script.sh
- hack/demo/resources/webhook-provider-certmanager/mutating-webhook-test.yaml
- hack/demo/single-namespace-demo-script.sh
- hack/demo/gzip-demo-script.sh
- hack/demo/synthetic-user-cluster-admin-demo-script.sh
- hack/demo/catalogd-metas-demo-script.sh
- hack/demo/resources/own-namespace-demo.yaml
- hack/demo/graphql-demo-server/main.go
- hack/demo/own-namespace-demo-script.sh
- hack/demo/resources/webhook-provider-certmanager/webhook-operator-extension.yaml
- hack/demo/generate-asciidemo.sh
- hack/demo/resources/synthetic-user-perms/argocd-clusterextension.yaml
✅ Files skipped from review due to trivial changes (6)
- README.md
- docs/draft/howto/enable-webhook-support.md
- docs/draft/howto/single-ownnamespace-install.md
- .gitignore
- hack/tools/test-profiling/go.mod
- mkdocs.yml
🚧 Files skipped from review as they are similar to previous changes (2)
- openshift/tests-extension/go.mod
- go.mod
Comment on lines
+718
to
726
| .PHONY: demo-svg | ||
| demo-svg: #EXHELP Convert asciicast recordings to SVG. | ||
| @command -v docker >/dev/null 2>&1 || { echo "Error: docker not found in PATH."; exit 1; } | ||
| @for cast in $(DEMO_OUTPUT_DIR)/*.cast; do \ | ||
| svg=$${cast%.cast}.svg; \ | ||
| echo "Converting $$(basename $$cast) -> $$(basename $$svg)"; \ | ||
| docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine \ | ||
| npx --yes svg-term-cli --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window; \ | ||
| done |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Unquoted glob can fail when no .cast files exist.
If $(DEMO_OUTPUT_DIR) contains no .cast files, the glob won't expand under default shell settings, so cast becomes the literal string $(DEMO_OUTPUT_DIR)/*.cast, and docker run will fail trying to mount/read a nonexistent file with a confusing error instead of a clear message.
🐛 Proposed fix using nullglob guard
demo-svg: `#EXHELP` Convert asciicast recordings to SVG.
`@command` -v docker >/dev/null 2>&1 || { echo "Error: docker not found in PATH."; exit 1; }
- `@for` cast in $(DEMO_OUTPUT_DIR)/*.cast; do \
+ `@shopt` -s nullglob; \
+ casts=($(DEMO_OUTPUT_DIR)/*.cast); \
+ if [ $${`#casts`[@]} -eq 0 ]; then \
+ echo "No .cast files found in $(DEMO_OUTPUT_DIR)"; \
+ exit 0; \
+ fi; \
+ for cast in "$${casts[@]}"; do \
svg=$${cast%.cast}.svg; \
echo "Converting $$(basename $$cast) -> $$(basename $$svg)"; \
docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine \
npx --yes svg-term-cli --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window; \
doneRequires bash as the recipe shell (for shopt/arrays) — verify SHELL is set to bash elsewhere in this Makefile, consistent with the [[ ]] usage already present at Line 411/422.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .PHONY: demo-svg | |
| demo-svg: #EXHELP Convert asciicast recordings to SVG. | |
| @command -v docker >/dev/null 2>&1 || { echo "Error: docker not found in PATH."; exit 1; } | |
| @for cast in $(DEMO_OUTPUT_DIR)/*.cast; do \ | |
| svg=$${cast%.cast}.svg; \ | |
| echo "Converting $$(basename $$cast) -> $$(basename $$svg)"; \ | |
| docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine \ | |
| npx --yes svg-term-cli --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window; \ | |
| done | |
| .PHONY: demo-svg | |
| demo-svg: `#EXHELP` Convert asciicast recordings to SVG. | |
| `@command` -v docker >/dev/null 2>&1 || { echo "Error: docker not found in PATH."; exit 1; } | |
| `@shopt` -s nullglob; \ | |
| casts=($(DEMO_OUTPUT_DIR)/*.cast); \ | |
| if [ $${`#casts`[@]} -eq 0 ]; then \ | |
| echo "No .cast files found in $(DEMO_OUTPUT_DIR)"; \ | |
| exit 0; \ | |
| fi; \ | |
| for cast in "$${casts[@]}"; do \ | |
| svg=$${cast%.cast}.svg; \ | |
| echo "Converting $$(basename $$cast) -> $$(basename $$svg)"; \ | |
| docker run --rm -v $(DEMO_OUTPUT_DIR):/data node:alpine \ | |
| npx --yes svg-term-cli --in /data/$$(basename $$cast) --out /data/$$(basename $$svg) --window; \ | |
| done |
🧰 Tools
🪛 checkmake (0.3.2)
[warning] 719-719: Target body for "demo-svg" exceeds allowed length of 5 lines (7).
(maxbodylength)
[warning] 719-719: Required target "all" is missing from the Makefile.
(minphony)
[warning] 719-719: Required target "clean" is missing from the Makefile.
(minphony)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Makefile` around lines 718 - 726, The demo-svg recipe currently iterates over
an unquoted *.cast glob, so when no recordings exist it passes a literal path
into docker and fails confusingly. Update the demo-svg target to use
bash-friendly glob handling in the recipe (consistent with the existing
bash-only [[ ]] usage) by enabling a no-match-safe pattern or explicitly
checking for matching files before the loop, and keep the existing demo-svg
command flow and symbols like demo-svg, DEMO_OUTPUT_DIR, and the for cast loop
intact.
Contributor
|
@openshift-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Tickets:
The downstream repository has been updated with the following following upstream commits:
The
vendor/directory has been updated and the following commits were carried:@catalogd-updateThis pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/assign @openshift/openshift-team-operator-runtime
Summary by CodeRabbit
New Features
Bug Fixes
Documentation