Skip to content

NO-JIRA: Fix Flaky e2e tests - Update the Cleanup order #31347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YamunadeviShanmugam wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

NO-JIRA: Fix Flaky e2e tests - Update the Cleanup order #31347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/extended/util/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,18 +1195,23 @@ func (c *CLI) GetClientConfigForUser(username string) *rest.Config {
}

privToken, pubToken := GenerateOAuthTokenPair()
token, err := oauthClient.OauthV1().OAuthAccessTokens().Create(ctx, &oauthv1.OAuthAccessToken{
_, err = oauthClient.OauthV1().OAuthAccessTokens().Create(ctx, &oauthv1.OAuthAccessToken{
ObjectMeta: metav1.ObjectMeta{Name: pubToken},
ClientName: oauthClientName,
UserName: username,
UserUID: string(user.UID),
Scopes: []string{"user:full"},
RedirectURI: "https://localhost:8443/oauth/token/implicit",
ExpiresIn: 21600, // 6 h TTL; auto-expires without explicit deletion
}, metav1.CreateOptions{})
if err != nil {
FatalErr(err)
}
c.AddResourceToDelete(oauthv1.GroupVersion.WithResource("oauthaccesstokens"), token)
// The token is intentionally not added to resourcesToDelete.
// TeardownProject (AfterEach) runs before DeferCleanup. Deleting the token
Comment thread
YamunadeviShanmugam marked this conversation as resolved.
// there causes cached clients to get 401 Unauthorized, fall back to
// system:anonymous, and fail with 403 Forbidden during DeferCleanup.
// ExpiresIn: 21600 provides TTL-based cleanup without breaking DeferCleanup.

userClientConfig := rest.AnonymousClientConfig(turnOffRateLimiting(rest.CopyConfig(c.AdminConfig())))
userClientConfig.BearerToken = privToken
Expand Down