Bump go-git/go-git/v5 from v5.17.0 to v5.19.1

[clcollins]

Summary

• Update go-git/go-git/v5 from v5.17.0 to v5.19.1, pulling in go-billy/v5 v5.9.0 with improved symlink resolution safety
• Align test helper AddGlob("*") to AddGlob(".") to match the production code pattern in app_interface_clone.go and accommodate stricter path validation in the updated go-git

Test plan

• go build ./... succeeds
• go test ./pkg/promote/... passes (33 specs)
• go test ./cmd/promote/... passes
• Pre-commit hooks pass (lint + docs generation)

REF: ROSAENG-61415
REF: ROSAENG-61153
REF: ROSAENG-61156
REF: ROSAENG-61151

🤖 Created with assistance from Claude claude@anthropic.com

Summary by CodeRabbit

• Chores
  • Updated several indirect dependencies to newer versions for improved reliability and security.
• Bug Fixes
  • Adjusted an internal staging step so file changes are captured more consistently during commit-related operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9806ac27-2f57-44f3-b8d6-73dc714817d8

📥 Commits

Reviewing files that changed from the base of the PR and between 581f65e and d378e46.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• go.mod
• pkg/promote/test_tools.go

---

Walkthrough

This change updates several indirect Go module dependencies in go.mod, including go-git/v5, go-billy/v5, circl, filepath-securejoin, and sha1cd, plus adds cpuid/v2. It also modifies a test helper to stage files with "." instead of "*" during worktree operations.

Changes

Dependency Updates

Layer / File(s)	Summary
Indirect dependency version bumps go.mod	Upgrades go-git/v5 (v5.17.0→v5.19.1), go-billy/v5 (v5.8.0→v5.9.0), circl (v1.6.1→v1.6.3), filepath-securejoin (v0.4.1→v0.6.1), sha1cd (v0.3.2→v0.6.0), and adds cpuid/v2 v2.3.0 as a new indirect dependency.
Worktree staging pattern fix pkg/promote/test_tools.go	Changes CommitAppInterfaceChanges to stage files using AddGlob(".") instead of AddGlob("*").

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: N/A

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main dependency upgrade in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only updates dependencies and a helper AddGlob call; no It/Describe/Context/When titles were added or changed in touched files.
Test Structure And Quality	✅ Passed	The PR only changes AddGlob("*") to AddGlob(".") in a git helper; specs already use AfterEach cleanup, with no Eventually/Consistently waits added.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the only test-file change is a git helper switch from AddGlob("*") to ".", with no MicroShift-unsupported APIs/features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the patch only updates go.mod and a promote test helper, with no SNO-assumption patterns present.
Topology-Aware Scheduling Compatibility	✅ Passed	No manifests, operator code, or controllers were modified; only go.mod/go.sum and a git test helper changed, with no scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	Only go.mod deps and a test helper changed; no stdout writes appear in touched files, and the helper mirrors existing AddGlob(".") production code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the only test change is AddGlob("*")→AddGlob(".") in a helper, with no IPv4 or external-network assumptions found.
No-Weak-Crypto	✅ Passed	No weak-crypto or secret-comparison code was added; the only SHA1-related item is a transitive go.mod bump, and the code change is just AddGlob(".").
Container-Privileges	✅ Passed	Diff only touches go.mod, go.sum, and a test helper; no container/K8s manifests or privilege settings were added or changed.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging or sensitive-data exposure appears in the changed hunks; the code change only switches AddGlob("*") to AddGlob(".") and bumps dependencies.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@clcollins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[joshbranham]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [clcollins,joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment