Add changes for checking E2E coverage with lgtm based approach for External-Secrets-Operator#81660
Add changes for checking E2E coverage with lgtm based approach for External-Secrets-Operator#81660siddhibhor-56 wants to merge 2 commits into
Conversation
siddhibhor-56
changed the title
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR restructures the CI configuration for the external-secrets-operator. The e2e-operator test flow is simplified to only run bundle install and make test-e2e, coverage steps are moved to a new e2e-operator-coverage job, and the repo is registered in the LGTM config for the main branch. ChangesCI Job Restructuring
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: siddhibhor-56 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core-services/pipeline-controller/lgtm-config.yaml (1)
17-17: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueStray blank line in repos list.
An empty line was inserted into the
openshiftorg'srepos:list right whereexternal-secrets-operatorwould alphabetically sort. This looks like an editing artifact rather than an intentional change — the actual entry was correctly added separately at Lines 35-37.🧹 Proposed cleanup
- egress-router-cni - - gcp-workload-identity-federation-webhook🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core-services/pipeline-controller/lgtm-config.yaml` at line 17, Remove the stray blank line from the openshift org repos list in lgtm-config.yaml so the list stays alphabetically contiguous; keep the external-secrets-operator entry in its correct sorted position and do not add any empty separator line in that section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@core-services/pipeline-controller/lgtm-config.yaml`:
- Line 17: Remove the stray blank line from the openshift org repos list in
lgtm-config.yaml so the list stays alphabetically contiguous; keep the
external-secrets-operator entry in its correct sorted position and do not add
any empty separator line in that section.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 65acbb1c-b1dc-459c-8c57-59f44bd48d7b
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/external-secrets-operator/openshift-external-secrets-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-main.yamlcore-services/pipeline-controller/lgtm-config.yaml
siddhibhor-56
force-pushed
the
more-codecov
branch
2 times, most recently
from
4c433eb to
01762cb
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
siddhibhor-56
force-pushed
the
more-codecov
branch
from
01762cb to
3e3d004
Compare
|
/pj-rehearse max |
|
@siddhibhor-56: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator-coverage |
|
@siddhibhor-56: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator |
|
@siddhibhor-56: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator |
|
@siddhibhor-56: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@siddhibhor-56: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
Adds Separates E2E coverage instrumentation from the main e2e-operator presubmit into a standalone e2e-operator-coverage test with
always_run: false, gated onLGTMvia pipeline-controllerSummary by CodeRabbit
This PR updates the OpenShift CI setup for
openshift/external-secrets-operatorto split E2E coverage collection out of the main presubmit path. The existinge2e-operatorjob now focuses on the operator install and E2E test execution, while coverage-specific steps are moved into a separatee2e-operator-coveragejob.The new coverage job is not run automatically (
always_run: false) and is configured to be triggered only when LGTM conditions are met through pipeline-controller. This keeps normal presubmit validation lighter while still preserving a dedicated coverage check for the repo’s main branch.