Enroll cluster-network-operator, cluster-kube-apiserver-operator, cluster-etcd-operator in pipeline controller LGTM mode#81736
Conversation
|
@jmguzik, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (65)
🚧 Files skipped from review as they are similar to previous changes (63)
WalkthroughThis change standardizes CI execution metadata across Etcd, Kube-apiserver, and Network Operator configurations by adding ChangesCI execution metadata
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
|
…ster-etcd-operator in pipeline controller LGTM mode Convert e2e tests across versions 4.12+ to use the pipeline controller second-stage model. Changes applied to both openshift and openshift-priv orgs. - skip_if_only_changed → pipeline_skip_if_only_changed - run_if_changed → pipeline_run_if_changed - Set always_run: false on required e2e tests - Add all 3 repos (both orgs) to lgtm-config.yaml 105 files changed across 6 repo/org combinations. Made with Cursor Signed-off-by: Jakub Guzik <jguzik@redhat.com>
bf12660 to
fac1492
Compare
|
[REHEARSALNOTIFIER]
A total of 567 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jmguzik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido, jmguzik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@jmguzik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Convert e2e tests across versions 4.12+ to use the pipeline controller second-stage model. Changes applied to both openshift and openshift-priv orgs.
105 files changed across 6 repo/org combinations.
Made with Cursor
Summary by CodeRabbit
core-services/pipeline-controller/lgtm-config.yamlto enrollcluster-network-operator,cluster-kube-apiserver-operator, andcluster-etcd-operatorin pipeline-controller LGTM mode for bothopenshiftandopenshift-priv(adjusting the per-org allowlists by removingassisted-service/installerandovn-kubernetes, and adding the three target repos).skip_if_only_changed→pipeline_skip_if_only_changedandrun_if_changed→pipeline_run_if_changedwhile keeping the existing regex gating behavior.always_run: falseon the relevant test step entries across both orgs and all six repository/organization combinations (spanning etcd, kube-apiserver, and network operator E2E workflows, including upgrade/conformance, OVN/AWS/GCP/Azure/metal IPI variants, and etcd recovery/event-ttl periodic jobs).