ROSAENG-62156 fix: add openshift version and channel group support for CAPA e2e - #82728
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe ROSA Capa-E2E step now accepts optional OpenShift version and channel group values. The test configuration sets OpenShift 4.22 and the nightly channel. The command passes these values and ChangesROSA Capa-E2E configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andclt
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh`:
- Around line 96-105: Update the EXTRA_VARS construction in the rosa-hcp-e2e
command flow to use a Bash array, appending each `-e` key/value pair as separate
elements and expanding it with `"${EXTRA_VARS[@]}"` when invoking
`run-test-suite.py`. Preserve the existing conditional variables and leave
`${TEST_SUITE}` unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: c73906e6-e611-42ca-aa28-4beb3deb1455
📒 Files selected for processing (3)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yamlci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.shci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-ref.yaml
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
e4930f2 to
56bfbc4
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
56bfbc4 to
f8fc195
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
f8fc195 to
98eac09
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
98eac09 to
7118c7d
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
7118c7d to
50ce263
Compare
|
@andclt: |
|
@andclt: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andclt, dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
Summary
This change allows the CAPA e2e periodic job to target latest stable HCP versions in staging.
Summary by CodeRabbit
The CAPA e2e periodic job now targets OpenShift
4.22from thenightlychannel in staging.The
rosa-e2e-capastep acceptsOPENSHIFT_VERSIONandCHANNEL_GROUPand passes them to the test suite. Empty values preserve repository defaults.