Skip to content

Add driver-toolkit qualifier for 5.0 nightly verification jobs - #82763

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:driver-toolkit-qualifier-5.0
Aug 3, 2026
Merged

Add driver-toolkit qualifier for 5.0 nightly verification jobs#82763
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:driver-toolkit-qualifier-5.0

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a new driver-toolkit release qualifier and associates it with the driver-toolkit and driver-toolkit-rhel10 verification jobs in the 5.0 nightly release configuration.

The driver-toolkit jobs have been fixed and are now passing — both succeeded with zero retries in payload 5.0.0-0.nightly-2026-07-31-091606.

Changes

core-services/release-controller/release-qualifiers.yaml

  • Added new driver-toolkit qualifier:
    • enabled: true
    • badgeName: "dtk"
    • summary: "Driver Toolkit Validation"
    • description: "Driver Toolkit Validation"
    • payloadBadgeStatus: "Yes"

core-services/release-controller/_releases/release-ocp-5.0.json

  • Added "qualifiers": { "driver-toolkit": {} } to the driver-toolkit verify job entry
  • Added "qualifiers": { "driver-toolkit": {} } to the driver-toolkit-rhel10 verify job entry

No other files or job entries are modified.


@neisw requested via Chai Bot

Summary by CodeRabbit

Adds the enabled driver-toolkit release qualifier with the dtk badge to the OpenShift 5.0 nightly release configuration. Associates the qualifier with the driver-toolkit and driver-toolkit-rhel10 verification jobs.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 31, 2026
@openshift-ci
openshift-ci Bot requested review from jupierce and psalajova July 31, 2026 21:18
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ea139ece-b94d-47c3-901b-15da0806d1ce

📥 Commits

Reviewing files that changed from the base of the PR and between f37d9a2 and 1bcf946.

📒 Files selected for processing (1)
  • core-services/release-controller/_releases/priv/release-ocp-5.0.json

Walkthrough

The release controller defines an enabled driver-toolkit qualifier and assigns it to the driver-toolkit and driver-toolkit-rhel10 verification jobs.

Changes

Driver Toolkit qualifier

Layer / File(s) Summary
Configure Driver Toolkit qualifier and verification jobs
core-services/release-controller/release-qualifiers.yaml, core-services/release-controller/_releases/release-ocp-5.0.json, core-services/release-controller/_releases/priv/release-ocp-5.0.json
The enabled qualifier defines the dtk badge, Driver Toolkit validation text, and unconditional payload badge display. Both verification configurations identify the driver-toolkit qualifier.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: jupierce, psalajova, rsevilla87

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes adding the driver-toolkit qualifier to the 5.0 nightly verification jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only generated JSON configuration by adding qualifier keys; it adds no Ginkgo test files or test-title calls.
Test Structure And Quality ✅ Passed The PR changes only release-controller YAML/JSON configuration. No Ginkgo test code, It blocks, or cluster operations are added or modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only release-controller YAML/JSON configuration; no new Ginkgo tests or test files were added, so MicroShift compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only release-controller YAML/JSON configuration; it adds no Ginkgo e2e tests, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only release-controller YAML/JSON qualifier metadata; it adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The aggregate PR diff changes only release-controller YAML/JSON configuration; it adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only release-controller YAML/JSON configuration files; it adds no Ginkgo e2e tests or network connectivity code.
No-Weak-Crypto ✅ Passed The PR changes only YAML and JSON release configuration. The diff contains no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges ✅ Passed The PR changes only release-controller JSON/YAML configuration; added lines contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only YAML/JSON qualifier data; no logging constructs or sensitive-data indicators appear in the added lines.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@petr-muller-reviewer: GitHub didn't allow me to request PR reviews from the following users: petr-muller-reviewer.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@petr-muller-reviewer: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@petr-muller

Copy link
Copy Markdown
Member

@redhat-chai-bot address the CI job failure

ERROR: This check enforces that Release Controller configuration files are generated
ERROR: correctly. We have automation in place that generates these configs and
ERROR: any changes must be included in your pull-request.
ERROR: Run the following command to re-generate the release controller configurations, run:
ERROR: $ make release-controllers

Regenerates core-services/release-controller/_releases/priv/release-ocp-5.0.json
to include the driver-toolkit qualifier, keeping generated output in sync
with the release-qualifiers.yaml and release-ocp-5.0.json changes.
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@petr-muller

Copy link
Copy Markdown
Member

/retest-required
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, petr-muller, petr-muller-reviewer, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 200e3d8 into openshift:main Aug 3, 2026
9 checks passed
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Updated the release-controller-release-qualifiers configmap in namespace ci at cluster app.ci using the following files:

  • key release-qualifiers.yaml using file core-services/release-controller/release-qualifiers.yaml
Details

In response to this:

Summary

Adds a new driver-toolkit release qualifier and associates it with the driver-toolkit and driver-toolkit-rhel10 verification jobs in the 5.0 nightly release configuration.

The driver-toolkit jobs have been fixed and are now passing — both succeeded with zero retries in payload 5.0.0-0.nightly-2026-07-31-091606.

Changes

core-services/release-controller/release-qualifiers.yaml

  • Added new driver-toolkit qualifier:
  • enabled: true
  • badgeName: "dtk"
  • summary: "Driver Toolkit Validation"
  • description: "Driver Toolkit Validation"
  • payloadBadgeStatus: "Yes"

core-services/release-controller/_releases/release-ocp-5.0.json

  • Added "qualifiers": { "driver-toolkit": {} } to the driver-toolkit verify job entry
  • Added "qualifiers": { "driver-toolkit": {} } to the driver-toolkit-rhel10 verify job entry

No other files or job entries are modified.


@neisw requested via Chai Bot

Summary by CodeRabbit

Adds the enabled driver-toolkit release qualifier with the dtk badge to the OpenShift 5.0 nightly release configuration. Associates the qualifier with the driver-toolkit and driver-toolkit-rhel10 verification jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jtaleric pushed a commit to jtaleric/release that referenced this pull request Aug 3, 2026
…hift#82763)

* Add driver-toolkit qualifier for 5.0 nightly verification jobs

* Run make release-controllers to regenerate priv 5.0 config

Regenerates core-services/release-controller/_releases/priv/release-ocp-5.0.json
to include the driver-toolkit qualifier, keeping generated output in sync
with the release-qualifiers.yaml and release-ocp-5.0.json changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants