Export WORKLOAD_IMAGE in upgrade e2e steps - #82777
Conversation
The 4.22-upgrade variant e2e-upgrade-test steps did not export WORKLOAD_IMAGE from SHARED_DIR/workload_image, causing upgrade tests to use a fallback image instead of the centrally defined workload image written by the medik8s-lib step. Add the same WORKLOAD_IMAGE export pattern used in the 4.22-konflux variant to both presubmit and periodic e2e-upgrade-test steps. Jira: RHWA-1397 Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe presubmit and scheduled AWS upgrade test commands now conditionally load ChangesAWS upgrade workload image
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Replace the silent fallback to ubi9/ubi-minimal with a panic when WORKLOAD_IMAGE is unset. This ensures CI misconfiguration (missing export in e2e-test commands) is caught immediately rather than silently using a default image. The fallback was added as a workaround while the upgrade CI variant lacked the WORKLOAD_IMAGE export. Now that openshift/release PR #82777 adds the export to all e2e-upgrade-test steps, the fallback can be removed. Depends-On: openshift/release#82777 Co-Authored-By: Claude <noreply@anthropic.com>
|
/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-upgrade-e2e-far-upgrade-presubmit-aws |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ugreener: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, ugreener The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
The medik8s E2E test infrastructure establishes a single source of truth for the workload image: the
medik8s-libCI step writes it toSHARED_DIR/workload_image, and each e2e-test step exports it asWORKLOAD_IMAGE. This allows the image to be changed in one place (medik8s-lib-commands.sh). The upgrade CI variant'se2e-upgrade-teststeps did not exportWORKLOAD_IMAGE, so they bypassed the centralized configuration entirely. As a result, upgrade tests silently used a fallback image instead of the shared one, and changing the image inmedik8s-libhad no effect on upgrade runs.Summary
Export
WORKLOAD_IMAGEfromSHARED_DIR/workload_imagein both upgradee2e-upgrade-teststeps (presubmit and periodic), matching the pattern already used across alle2e-teststeps in the4.22-konfluxvariant (PR #82523).Changes
e2e-upgrade-teststep to exportWORKLOAD_IMAGEfromSHARED_DIR/workload_imagebeforemake run-testse2e-upgrade-teststep with the same patternJira: RHWA-1397