Skip to content

Remove cluster-image-registry-operator's no-FF requirements - #82832

Open
patrickdillon wants to merge 1 commit into
openshift:mainfrom
patrickdillon:ciro-labels
Open

Remove cluster-image-registry-operator's no-FF requirements#82832
patrickdillon wants to merge 1 commit into
openshift:mainfrom
patrickdillon:ciro-labels

Conversation

@patrickdillon

@patrickdillon patrickdillon commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The docs-approved, px-approved label requirements are legacy. This process is no longer used.

Summary by CodeRabbit

  • Updated the cluster-image-registry-operator Prow configuration.
  • Removed obsolete docs-approved and px-approved label requirements from Tide no-fast-forward checks.
  • Removed unused branch-specific Tide queries.

The docs-approved, px-approved label requirements are legacy. This
process is no longer used.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8938f670-3af4-4877-bd37-ef95953b916e

📥 Commits

Reviewing files that changed from the base of the PR and between 3620265 and 894b699.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift/cluster-image-registry-operator/_prowconfig.yaml
💤 Files with no reviewable changes (1)
  • core-services/prow/02_config/openshift/cluster-image-registry-operator/_prowconfig.yaml

Walkthrough

The Prow Tide configuration removes obsolete excluded-branch and separate branch queries. The remaining main/master query uses updated bug-validation labels.

Changes

Cohort / File(s) Summary
Tide query cleanup
core-services/prow/02_config/openshift/cluster-image-registry-operator/_prowconfig.yaml
Removes obsolete Tide query definitions and label requirements. Updates bug-validation labels in the remaining main/master query.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the removal of the cluster-image-registry-operator's no-fast-forward requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only _prowconfig.yaml; it adds or modifies no Ginkgo test declarations or test titles.
Test Structure And Quality ✅ Passed The PR changes only _prowconfig.yaml and the target directory contains no Ginkgo test files, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only one YAML configuration file and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one YAML configuration file and adds no Ginkgo e2e tests, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only a Prow YAML configuration file and removes label-query entries; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only a Prow YAML configuration file; it adds or modifies no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit only deletes 87 lines from a Prow YAML file. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed HEAD changes only one Prow YAML file and delete 87 label/query lines; no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons are introduced.
Container-Privileges ✅ Passed The PR changes only a Prow Tide configuration file; the diff adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only deletes Tide YAML query entries; it adds no logging statements, log fields, credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign tjungblu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@patrickdillon: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant