Skip to content

fix: we deploy from the root#379

Merged
mkleene merged 1 commit into
mainfrom
fix-deploy
Jun 22, 2026
Merged

fix: we deploy from the root#379
mkleene merged 1 commit into
mainfrom
fix-deploy

Conversation

@mkleene

@mkleene mkleene commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

We just include the new module in the root pom.

Summary by CodeRabbit

  • Chores
    • Updated release build configuration to include FIPS-compliant module in distribution releases.
    • Simplified build and deployment plugin configurations.

@mkleene mkleene requested review from a team as code owners June 22, 2026 18:42
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3cddedab-065b-4864-8a61-1df27d66e74d

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd086e and b0c9d8e.

📒 Files selected for processing (2)
  • pom.xml
  • sdk-fips-bouncycastle/pom.xml
💤 Files with no reviewable changes (1)
  • sdk-fips-bouncycastle/pom.xml

📝 Walkthrough

Walkthrough

The root pom.xml adds sdk-fips-bouncycastle to the release Maven profile's module list. Correspondingly, sdk-fips-bouncycastle/pom.xml removes its entire <build> section, which previously contained the central-publishing-maven-plugin and a maven-deploy-plugin execution that skipped the deploy phase.

Changes

Release Profile and Publishing Configuration

Layer / File(s) Summary
Release profile inclusion and build config removal
pom.xml, sdk-fips-bouncycastle/pom.xml
sdk-fips-bouncycastle is added to the root release profile's <modules> list; its own <build> block (containing central-publishing-maven-plugin auto-publish settings and a maven-deploy-plugin phase none execution) is removed entirely.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hippity-hoppity, down the release trail,
A module forgotten now joins without fail!
The build block was snipped — no plugins to spare,
The parent will publish with elegant flair.
One line in, twenty-nine out — what a trade!
This bouncy BouncyCastle finally got paid. 🏰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: we deploy from the root' accurately captures the main change: adjusting the release profile and build configuration to deploy from the root pom.xml rather than individual modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-deploy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the sdk-fips-bouncycastle module to the release profile in the root pom.xml and removes the custom build plugins (central-publishing-maven-plugin and maven-deploy-plugin) from the sdk-fips-bouncycastle/pom.xml file. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@mkleene mkleene merged commit 3b612dd into main Jun 22, 2026
22 checks passed
@mkleene mkleene deleted the fix-deploy branch June 22, 2026 19:05
mkleene pushed a commit that referenced this pull request Jun 22, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>0.17.0</summary>

##
[0.17.0](v0.16.0...v0.17.0)
(2026-06-22)


### Features

* **sdk:** DSPX-3309 add hybrid post-quantum key wrapping for KAS
(X-Wing, ECDH+ML-KEM)
([#368](#368))
([faffa7d](faffa7d))


### Bug Fixes

* do not push snapshots
([#381](#381))
([b761453](b761453))
* we deploy from the root
([#379](#379))
([3b612dd](3b612dd))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants