Skip to content

fix: do not push snapshots#381

Merged
mkleene merged 5 commits into
mainfrom
do-not-push-snapshots
Jun 22, 2026
Merged

fix: do not push snapshots#381
mkleene merged 5 commits into
mainfrom
do-not-push-snapshots

Conversation

@mkleene

@mkleene mkleene commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

publish to both github packages and central on a release

Summary by CodeRabbit

  • Chores
    • Optimized the release workflow to streamline the publishing process for package deployment.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 887d2322-e50c-40b0-a5ba-8b9c8673d9c7

📥 Commits

Reviewing files that changed from the base of the PR and between 3b612dd and 0470e5e.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

📝 Walkthrough

Walkthrough

The release GitHub Actions job gains a single job-level if condition that restricts execution to tag refs (refs/tags/...). The previously separate step-level conditions gating GitHub Packages publishing on refs/heads/main and Maven Central publishing on tag refs are removed, so both deploy steps now run unconditionally whenever the job runs.

Changes

Release CI Job Condition Consolidation

Layer / File(s) Summary
Job-level condition and step guard removal
.github/workflows/release.yaml
Adds if: startsWith(github.ref, 'refs/tags/') at the job level and removes the step-level if: github.ref == 'refs/heads/main' guard on the GitHub Packages (stage profile) steps and the if: startsWith(github.ref, 'refs/tags/') guard on the Maven Central (release profile) steps. Both deploy steps now execute whenever the job runs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 A single condition to rule them all,
No more step-by-step guards down the hall.
Tag the release, the job shall awake,
Stage and deploy in one fell swake.
Simplicity hops — what a joyful update! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'fix: do not push snapshots' is vague and does not clearly reflect the actual changes made to the release workflow. Revise the title to be more specific about the workflow change, such as 'fix: conditionally run release job on tags only' or 'fix: prevent snapshot publishing by gating release job on tag refs'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch do-not-push-snapshots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

X-Test Failure Report

@github-actions

Copy link
Copy Markdown
Contributor

X-Test Failure Report

@mkleene mkleene marked this pull request as ready for review June 22, 2026 19:49
@mkleene mkleene requested review from a team as code owners June 22, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

X-Test Failure Report

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@mkleene mkleene merged commit b761453 into main Jun 22, 2026
22 checks passed
@mkleene mkleene deleted the do-not-push-snapshots branch June 22, 2026 20:16
mkleene pushed a commit that referenced this pull request Jun 22, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>0.17.0</summary>

##
[0.17.0](v0.16.0...v0.17.0)
(2026-06-22)


### Features

* **sdk:** DSPX-3309 add hybrid post-quantum key wrapping for KAS
(X-Wing, ECDH+ML-KEM)
([#368](#368))
([faffa7d](faffa7d))


### Bug Fixes

* do not push snapshots
([#381](#381))
([b761453](b761453))
* we deploy from the root
([#379](#379))
([3b612dd](3b612dd))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants