[#741, 742] App target의 Firebase plist 경로를 단일 파일로 유지하고 앱 환경 판별과 Firebase 설정 누락 처리를 분리한다#748
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 Firebase 환경(staging 또는 prod)에 따라 적절한 GoogleService-Info.plist 파일을 동적으로 설치하도록 GitHub Action 및 앱 설정을 개선하고, FirebaseConfiguration의 환경 변수 및 번들 값 분석 로직을 리팩토링하며 테스트 코드를 추가했습니다. 피드백으로는 매번 호출 시마다 ProcessInfo와 Bundle을 조회하는 연산 프로퍼티인 databaseID를 static let 상수와 클로저 초기화 방식으로 변경하여 성능을 개선하라는 제안이 있었습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
Apptarget과Appscheme, 공통GoogleService-Info.plist경로를 유지하면서 배포 흐름에 맞는 Firebase 설정을 GitHub Actions에서 선택하도록 구성📝 작업 내용
📌 요약
install-private-config에 필수environment입력 추가APP_ENVIRONMENT기반 앱 환경 판별 추가FirebaseConfiguration의 staging 기본값 제거와 필수 설정 누락 처리 강화🔍 상세
Apptarget과Appscheme을 분리하지 않고 기존 빌드 구조 유지Application/App/Sources/Resource/GoogleService-Info.plist공통 경로에 하나만 설치하는 흐름 구성install-private-config에서staging입력 시GoogleService-Info-Staging.plist,prod입력 시GoogleService-Info-Prod.plist선택environment: staging지정environment: prod지정Debug와Stagingconfiguration에APP_ENVIRONMENT=staging,Releaseconfiguration에APP_ENVIRONMENT=prod지정SettingsFeature의 prod 환경 판별 기준을FIRESTORE_DATABASE_ID에서APP_ENVIRONMENT로 분리FIRESTORE_DATABASE_ID누락 또는 미치환 시 staging으로 대체하지 않고 설정 해석 시 실패하도록 변경FUNCTION_API_BASE_URL누락, 미치환 값, 상대 경로를URLError.badURL로 처리GoogleService-Info-Staging.plist와GoogleService-Info-Prod.plist준비 필요📸 영상 / 이미지 (Optional)