[#744] TestFlight와 App Store IPA의 Firebase 설정을 검증한다#749
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 fastlane/Fastfile에서 verify_store_info_plist 메서드를 리팩토링하여 개별 인자 대신 구조화된 expected_configuration 해시를 받도록 수정하고, 앱 환경 변수 및 Firebase 설정 값들에 대한 검증 로직을 추가하였습니다. 리뷰어는 Shellwords가 로드되기 전에 사용되어 NameError가 발생할 수 있는 문제를 지적하며, require "shellwords"를 메서드 시작 부분으로 이동하고 중복된 임포트를 제거할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
APP_ENVIRONMENT환경별 기대값 추가Info.plist와GoogleService-Info.plist검증 추가expected_configuration으로 묶어 공통 검증기에 전달🔍 상세
APP_ENVIRONMENT=staging, App Store의APP_ENVIRONMENT=prod기대값 구성Payload/DevLog.app/Info.plistPayload/DevLog.app/GoogleService-Info.plistInfo.plist의 다음 항목 검증APP_ENVIRONMENTCFBundleIdentifierFIRESTORE_DATABASE_IDFUNCTION_API_BASE_URLFirebaseCrashlyticsCollectionEnabledGoogleService-Info.plist의 다음 항목 검증PROJECT_IDGOOGLE_APP_IDBUNDLE_IDPROJECT_ID와GOOGLE_APP_ID기대값이 함께 전달된 경우 실제 값과 비교required_plist_value,verify_plist_value를 통한 누락·빈 값·불일치 오류 메시지 통일build_for_store,upload_testflight_build,upload_appstore_build에서 동일한verify_store_info_plist사용(default)database ID 및 공통apiURL 연결은 #745와 #746으로 유지검증 결과
ruby -c fastlane/Fastfile통과bundle exec fastlane lanes통과git diff --check -- fastlane/Fastfile통과PROJECT_ID검증 실패 확인GOOGLE_APP_ID검증 실패 확인Pass📸 영상 / 이미지 (Optional)