-
Notifications
You must be signed in to change notification settings - Fork 0
[#787] 로컬 웹뷰 마크다운 렌더러를 모듈화한다 #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ee392e0
refactor: MarkdownRenderer 파일 경계 분리
opficdev 6b5e49f
refactor: MarkdownRenderer Swift 연결 경계 축소
opficdev e41f9bd
refactor: MarkdownRenderer 참조 계약 범용화
opficdev 4a7b77f
refactor: MarkdownRenderer 독립 모듈 구성
opficdev f597e3d
ci: MarkdownRenderer 검증 경로 연결
opficdev 34f17cf
docs: MarkdownRenderer 모듈 경계 문서화
opficdev afd3595
chore: .gemini 내용 제거
opficdev 4dded9c
fix: MarkdownRenderer 프레임워크 번들 구조 수정
opficdev 079079f
chore: .gemini 선행 읽기 요구 제거
opficdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # 컴파일된 JavaScript 문자열의 공백을 보존 | ||
| Application/Presentation/PresentationShared/Resources/MarkdownRenderer/renderer.js -whitespace | ||
| Libraries/MarkdownRenderer/Resources/MarkdownRenderer/renderer.js -whitespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
...tation/PresentationShared/Sources/Common/MarkdownRenderer/MarkdownRendererReference.swift
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import ProjectDescription | ||
| import ProjectDescriptionHelpers | ||
|
|
||
| let deploymentSettings: SettingsDictionary = [ | ||
| "IPHONEOS_DEPLOYMENT_TARGET": "17.0", | ||
| "MARKETING_VERSION": "1.0.0", | ||
| ] | ||
|
|
||
| let project = Project( | ||
| name: "MarkdownRenderer", | ||
| options: .options( | ||
| disableBundleAccessors: true, | ||
| disableSynthesizedResourceAccessors: true | ||
| ), | ||
| packages: [], | ||
| settings: .devlogProject(additionalBase: deploymentSettings), | ||
| targets: [ | ||
| .target( | ||
| name: "MarkdownRenderer", | ||
| destinations: .iOS, | ||
| product: .framework, | ||
| bundleId: "com.opfic.DevLog.MarkdownRenderer", | ||
| infoPlist: .extendingDefault( | ||
| with: ["CFBundlePackageType": "FMWK"] | ||
| ), | ||
| sources: ["Sources/**/*.swift"], | ||
| resources: [ | ||
| "Resources/MarkdownRenderer/index.html", | ||
| "Resources/MarkdownRenderer/renderer.css", | ||
| "Resources/MarkdownRenderer/renderer.js", | ||
| ], | ||
| scripts: [ | ||
| DevLogScripts.swiftLint( | ||
| sourcePath: "Sources", | ||
| configPath: "Sources/.swiftlint.yml" | ||
| ), | ||
| ], | ||
| dependencies: [], | ||
| settings: .devlog( | ||
| base: deploymentSettings.merging( | ||
| [ | ||
| "ENABLE_USER_SCRIPT_SANDBOXING": "NO", | ||
| ] | ||
| ) { _, new in new } | ||
| ) | ||
| ), | ||
| .target( | ||
| name: "MarkdownRendererTests", | ||
| destinations: .iOS, | ||
| product: .unitTests, | ||
| bundleId: "com.opfic.DevLog.MarkdownRendererTests", | ||
| infoPlist: .extendingDefault( | ||
| with: ["CFBundlePackageType": "BNDL"] | ||
| ), | ||
| sources: ["Tests/**/*.swift"], | ||
| scripts: [ | ||
| DevLogScripts.swiftLint( | ||
| sourcePath: "Tests", | ||
| configPath: "Tests/.swiftlint.yml" | ||
| ), | ||
| ], | ||
| dependencies: [ | ||
| .target(name: "MarkdownRenderer"), | ||
| ], | ||
| settings: .devlog( | ||
| base: deploymentSettings.merging( | ||
| [ | ||
| "ENABLE_USER_SCRIPT_SANDBOXING": "NO", | ||
| "TEST_TARGET_NAME": "MarkdownRenderer", | ||
| ] | ||
| ) { _, new in new } | ||
| ) | ||
| ), | ||
| ] | ||
| ) |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.