Skip to content

dns/bind: add validate-except config option (#5549) #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cm-rudolph wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −0
Open

dns/bind: add validate-except config option (#5549) #5550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/general.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@
<type>dropdown</type>
<help>Default is "No". Set to "Auto" to use the static trust anchor configuration by the system.</help>
</field>
<field>
<id>general.validate_except</id>
<label>DNSSEC Validate Except</label>
<type>select_multiple</type>
<style>tokenize</style>
<allownew>true</allownew>
<help>Specify a list of domain names at and beneath which DNSSEC validation should not be performed (essential for internal split DNS zones in forward zones).</help>
</field>
<field>
<id>general.hidehostname</id>
<label>Hide Hostname</label>
Expand Down
7 changes: 7 additions & 0 deletions dns/bind/src/opnsense/mvc/app/models/OPNsense/Bind/General.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@
<Default>no</Default>
<Required>Y</Required>
</dnssecvalidation>
<validate_except type="HostnameField">
<Required>N</Required>
<AsList>Y</AsList>
<IsDNSName>Y</IsDNSName>
<IpAllowed>N</IpAllowed>
<ValidationMessage>[%s] is not a valid domain name.</ValidationMessage>
</validate_except>
<hidehostname type="BooleanField">
<Default>0</Default>
<Required>Y</Required>
Expand Down
7 changes: 7 additions & 0 deletions dns/bind/src/opnsense/service/templates/OPNsense/Bind/named.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ options {
{% if helpers.exists('OPNsense.bind.general.dnssecvalidation') and OPNsense.bind.general.dnssecvalidation != '' %}
dnssec-validation {{ OPNsense.bind.general.dnssecvalidation }};
{% endif %}
{% if helpers.exists('OPNsense.bind.general.validate_except') and OPNsense.bind.general.validate_except != '' %}
validate-except {
{% for domain in OPNsense.bind.general.validate_except.split(',') %}
"{{ domain }}";
{% endfor %}
};
{% endif %}
{% if helpers.exists('OPNsense.bind.general.hidehostname') and OPNsense.bind.general.hidehostname == '1' %}
hostname none;
{% endif %}
Expand Down