[GR-75959] Optimize C extension fastcall keyword-name handling.#901
Closed
graalvmbot wants to merge 12 commits into
Closed
[GR-75959] Optimize C extension fastcall keyword-name handling.#901graalvmbot wants to merge 12 commits into
graalvmbot wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In macro benchmark
c-pydantic-validate, I've observed a lot of time spent in small C API upcalls and a large number of short-lived managed objects that are only created to be handed to native code.Main changes:
EnsurePythonObjectNodeand avoid boxing primitive values when they can be represented as tagged native handles.METH_FASTCALL | METH_KEYWORDSkeyword-name tuple directly as a native tuple with interned string elements.PyTuple_Newin C and allocate a nativePyTupleObjectinstead of creating a managed tuple with native sequence storage. Therefore, adjust tuple checks and type handling to account for native tuples.Further, this includes small follow-up cleanups around native reference handling and inlining cutoffs that came up while reducing the C API overhead.