Skip to content

Fix an e2e flake, maybe: use fillNumberInput #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Jun 26, 2026
Merged

Fix an e2e flake, maybe: use fillNumberInput #3265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/e2e/firewall-rules.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
expect,
expectRowVisible,
fillAndSelectComboboxOption,
fillNumberInput,
selectOption,
test,
type Locator,
Expand Down Expand Up @@ -41,7 +42,7 @@ test('can create firewall rule', async ({ page }) => {
await page.fill('input[name=name]', 'my-new-rule')
await page.getByRole('radio', { name: 'Outbound' }).click()

await page.fill('role=textbox[name="Priority"]', '5')
await fillNumberInput(page.getByRole('textbox', { name: 'Priority' }), '5')

// add targets with overlapping names and types to test delete
const targets = page.getByRole('table', { name: 'Targets' })
Expand Down Expand Up @@ -583,7 +584,7 @@ test('name conflict error on edit', async ({ page }) => {
await nameField.fill('allow-icmp')

// changing a value _without_ changing the name is allowed
await page.getByRole('textbox', { name: 'Priority' }).fill('37')
await fillNumberInput(page.getByRole('textbox', { name: 'Priority' }), '37')
await page.getByRole('button', { name: 'Update rule' }).click()
await expect(error).toBeHidden()
await expectRowVisible(page.getByRole('table'), { Name: 'allow-icmp', Priority: '37' })
Expand Down
Loading