fix: decode ECN codepoint 0b11 as CongestionExperienced - #35
Merged
FelixMcFelix merged 1 commit intoJul 25, 2026
Merged
Conversation
thomaseizinger
force-pushed
the
claude/ip-packet-ingot-refactor-3wzbin
branch
2 times, most recently
from
July 17, 2026 04:44
cebbfb2 to
be8cca2
Compare
Contributor
Author
|
@FelixMcFelix Could you take a look at this please? |
FelixMcFelix
approved these changes
Jul 24, 2026
FelixMcFelix
left a comment
FelixMcFelix
left a comment
Collaborator
There was a problem hiding this comment.
This looks good; thanks for the catch here.
Collaborator
|
@thomaseizinger I think CI will pass once you rebase on/merge main, if you could do so please? |
`Ecn::from_network` and `Ecn::try_from` both mapped the wire value 3 (CE, "Congestion Experienced") to `Ecn::Capable0`, silently collapsing the CE marking into ECT(1) on the next serialisation and dropping the congestion signal. Decode it to the existing `Ecn::CongestionExperienced` variant instead so all four RFC 3168 codepoints round-trip.
thomaseizinger
force-pushed
the
claude/ip-packet-ingot-refactor-3wzbin
branch
from
July 24, 2026 22:36
be8cca2 to
e63b00f
Compare
Contributor
Author
Done! Rebased onto latest main. |
Contributor
Author
|
At patch-release with these changes in it would be much appreciated 🙏 |
thomaseizinger
added a commit
to firezone/firezone
that referenced
this pull request
Jul 31, 2026
Related: #14108 Related: oxidecomputer/ingot#35 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ecn::from_networkandEcn::try_fromboth mapped the wire value 3 (CE, "Congestion Experienced") toEcn::Capable0, silently collapsing the CE marking into ECT(1) on the next serialisation and dropping the congestion signal. Decode it to the existingEcn::CongestionExperiencedvariant instead so all four RFC 3168 codepoints round-trip.