buildomat: collect .falcon if falcon-lab fails#807
Open
taspelund wants to merge 2 commits into
Open
Conversation
Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
nicolaskagami
approved these changes
Jun 26, 2026
nicolaskagami
left a comment
nicolaskagami
left a comment
There was a problem hiding this comment.
LGTM, whatever that's worth as a newbie :)
Just had a couple of questions below.
| # future Falcon versions may add other files here. | ||
| rm -rf "${artifact_dir}" | ||
| mkdir -p "${artifact_dir}" | ||
| for path in .falcon/*.{out,err}; do |
There was a problem hiding this comment.
Are all out/err files of interest in this folder? This doesn't catch anything in subdirectories.
Contributor
Author
There was a problem hiding this comment.
As of today, the only items in subdirectories are binaries. So this deliberately leaves those items behind. Good question though!
Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.