[4/n] [sync-switch] replace db-model builder inputs with domain types#10645
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
This was referenced Jun 20, 2026
andrewjstone
approved these changes
Jun 26, 2026
|
|
||
| /// A port's TX-EQ overrides. | ||
| pub struct TxEqInput { | ||
| pub pre1: Option<i32>, |
Contributor
There was a problem hiding this comment.
I know you didn't create these names, and they may even be domain specific. They do however make me want to iron the wrinkles out of my brain.
| pub pre1: Option<i32>, | ||
| pub pre2: Option<i32>, | ||
| pub main: Option<i32>, | ||
| pub post2: Option<i32>, |
Contributor
There was a problem hiding this comment.
Is this ordering of post2 before post1 intentional?
| /// A port's LLDP settings. | ||
| pub struct LldpInput { | ||
| pub enabled: bool, | ||
| pub link_name: Option<String>, |
Contributor
There was a problem hiding this comment.
Do we know if these are all optional semantically? Again, I know this is a refactoring, I'm just wondering if we can clean this up later? Do you do that in future PRs?
| return None; | ||
| } | ||
| None => { | ||
| error!(log, "rack subnet not set"; "rack" => ?rack); |
| use super::*; | ||
|
|
||
| #[test] | ||
| fn peerless_port_needs_no_switch_bgp_config() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow a pattern similar to the reconfigurator. This allows nexus-switch-config to drop the dependency on nexus-db-model and nexus-db-queries.
Also add a test for a non-BGP port.
Depends on: