Skip to content

feat(display): host companion controls in Presentation#141

Merged
papi-ux merged 1 commit into
masterfrom
fix/v1.3.2-thor-presentation-controls
Jul 12, 2026
Merged

feat(display): host companion controls in Presentation#141
papi-ux merged 1 commit into
masterfrom
fix/v1.3.2-thor-presentation-controls

Conversation

@papi-ux

@papi-ux papi-ux commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the external-display companion Activity with a Game-owned Presentation
  • place companion controls on the explicitly requested display while preserving stream launch routing
  • retain both public static JVM focus entry points for Java callers
  • clean up the Presentation with the owning Game lifecycle

Compatibility and safety

  • keeps requestFocusToExternalDisplayControl(Context) and requestFocusToExternalDisplayControl(Context, int) as @JvmStatic APIs
  • removes the companion Activity declaration and avoids focusable overlay/window behavior
  • preserves explicit display selection through receiver and trampoline paths
  • physical Thor verification remains a final validation gate; local JVM evidence is not presented as physical-device proof

Test plan

  • :app:testRootDebugUnitTest — 762/762
  • :app:testNonRoot_gameDebugUnitTest — 756/756
  • reflected both public static JVM overloads with correct reference/primitive parameter types
  • deletion mutation for the Context-only overload fails the compatibility test
  • independent production/runtime review PASS
  • independent compatibility test-contract review PASS

Refs #127

Move the external-display companion controls into a Game-owned Presentation, preserve JVM compatibility entry points, and route stream launch to the requested display with lifecycle and source-contract coverage.
@papi-ux
papi-ux merged commit d695f47 into master Jul 12, 2026
6 checks passed
@papi-ux
papi-ux deleted the fix/v1.3.2-thor-presentation-controls branch July 12, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant