fix: prevent stale companion controls after teardown#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents stale Nova companion controls from surviving or reopening after stream teardown.
Presentationwhen streaming stops;Gameis finishing/destroyed;Presentationcleanup and API 21 compatibility.Lifecycle contract
CompanionControlLifecyclePolicy.canShow(...)allows companion controls only when all three live conditions hold:The decision is made on the UI thread when the queued reopen callback executes, rather than using stale state captured when the request was queued.
Verification
Reviewed commit:
Exact reviewed binary-diff SHA-256:
Base/current
origin/masterat freeze:Fresh pc-papi gates:
Unsigned APK metadata:
com.papi.novacom.papi.novacom.papi.novaScope boundary
This PR does not install an APK, claim Retroid/Thor hardware validation, publish a release, or deploy/restart Polaris. Physical Thor remains a separate v1.3.2 release gate.