fix(server): stop emitting an empty interrupt frame at natural end of…#292
Open
decrypto21 wants to merge 1 commit into
Open
fix(server): stop emitting an empty interrupt frame at natural end of…#292decrypto21 wants to merge 1 commit into
decrypto21 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A subscription stream that ends naturally no longer emits a zero-length interrupt frame. Natural end of stream emits nothing; only an explicit interrupt carries a terminal frame.
Slot cleanup is unchanged: the subscription task still removes its own generation's slot, and a superseding reservation still owns its own cleanup.
Why (this is D6 from #271)
No deployed host signals natural end of stream on the wire - the novasama
host-containersends receive frames only. The core's extra empty interrupt frame is a conformance divergence, and the generated TS client treats the zero-length payload as an undecodable interrupt - so at best it is noise, at worst a decode error surfaced to the product.This is decision-independent of the error-shape direction (#271 D4 → #259): it is about emitting a frame at all at natural end, not the shape of error frames. It previously rode the flat-wire branch (#285); with that PR closed in favour of #259, this ships on its own - same rationale as the novasama terminal-frames fix (paritytech/triangle-js-sdks#228), which is the mirror image (host answers a frame on every fault; core stays silent on natural end).
Evidence
truapi-serverunit tests updated in place:register_completion_emits_no_terminal_frame(wasregister_completion_emits_interrupt), supersede/stop/dispose cases assert no stray frames.cargo test -p truapi-servergreen (310 tests).592dc4b): S1 stream-end now "receive only" on both sides (W1-Convergence-Run-2026-07-16.md, row S1).Relates to #271 (D6).