Conversation
Resolves the AccountAlias review-fixture conflict in favor of main's shape (shared PROOF_CONTEXT/RING_LOCATION constants plus the CreateProof case), which supersedes the branch-side repair of the same fixture. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ERussel
reviewed
Jul 20, 2026
|
|
||
| ### ECDH key derivations | ||
|
|
||
| Keys used for ECDH-based E2E encryption are **sr25519** keys, hard-derived |
There was a problem hiding this comment.
ECDH keys are not sr25519. Currently, P-256 NIST keys are used but we need to migrate to x25519 as it is faster, supported by community (most recent protocols, for example, TLS 1.3 uses it. The only problem I see here is that we need to use a standard for HDKD but one we have SLIP-0010 uses numbers as path component whereas we suggesting to use arbitrary UTF-8 strings.
Contributor
Author
There was a problem hiding this comment.
Bad wording here. What's meant is that we use sr25510 + substrate derivations and then hash the private key to obtain material for the p256 keys. Will fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered