Skip to content

fix: scan all Mach-O binaries for bundle linkage, not just .so/.dylib #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asheshv merged 2 commits into from
Jul 24, 2026
+4 −1
Merged

fix: scan all Mach-O binaries for bundle linkage, not just .so/.dylib #10189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6550983
fix: scan all Mach-O binaries for bundle linkage, not just .so/.dylib
asheshv Jul 24, 2026
93ae6c1
fix: don't skip non-executable Mach-O libraries in bundle scan
asheshv Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/mac/build-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,10 @@ _verify_bundle_linkage() {
echo "ERROR: ${f} links against build-host libraries:" >&2
echo "${deps}" | sed 's/^/ /' >&2
found="yes"
done < <(find "${BUNDLE_DIR}" \( -name '*.so' -o -name '*.dylib' \) -type f)
done < <(find "${BUNDLE_DIR}" -type f -exec file "{}" \; | \
grep -v "(for architecture" | \
grep -E "Mach-O executable|Mach-O 64-bit executable|Mach-O 64-bit bundle|Mach-O 64-bit dynamically linked shared library" | \
awk -F":" '{print $1}' | uniq)

if [ -n "${found}" ]; then
echo "ERROR: the bundle links against libraries outside it; those paths" >&2
Expand Down
Loading