Added support for MPEG Audio Layer I#71
Open
Slamy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do have to say that this is my first PR ever, created using generative AI. GPT 5.5 with Codex in this case.
I would like to mention that, because I'm still not sure if I'm a fan of this and I do know that there are people around that hate it.
Since MPEG Layer I is already a solved algorithm in many projects, I've tried to utilize this fact for adding support.
I've checked for regressions using "bjork-all-is-full-of-love.mpg".
I'm not sure if this handles every type of MPEG Audio Layer I but I've reviewed the code and I recognize certain patterns.
Tested the Audio Layer I support using MPEG stream from "AIMS - Learning About Ecology (1995)(AIMS Multimedia)(US)[DVC]" from a CD-i disc.