Skip to content

Fix GH-22138: skip libxml/xmlreader tests on non-ASCII paths. #22150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnexen wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+12 −2
Open

Fix GH-22138: skip libxml/xmlreader tests on non-ASCII paths. #22150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ext/libxml/tests/bug61367-read_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dom
--SKIPIF--
<?php
if (LIBXML_VERSION < 20912) die('skip For libxml2 >= 2.9.12 only');
if (preg_match('/[^\x00-\x7F]/', __DIR__)) die('skip path contains non-ASCII characters that libxml URI parser rejects');
?>
--INI--
open_basedir=.
Expand Down Expand Up @@ -58,6 +59,6 @@ bool(true)
int(4)
bool(true)

%s: DOMDocument::loadXML(): %Sfailed to load %s
%s: DOMDocument::loadXML(): %s

Warning: Attempt to read property "nodeValue" on null in %s on line %d
3 changes: 2 additions & 1 deletion ext/libxml/tests/libxml_disable_entity_loader_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ dom
--SKIPIF--
<?php
if (LIBXML_VERSION < 20912) die('skip For libxml2 >= 2.9.12 only');
if (preg_match('/[^\x00-\x7F]/', __DIR__)) die('skip path contains non-ASCII characters that libxml URI parser rejects');
?>
--FILE--
<?php
Expand Down Expand Up @@ -40,6 +41,6 @@ bool(true)
Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0, as external entity loading is disabled by default in %s on line %d
bool(false)

%s: DOMDocument::loadXML(): %Sfailed to load %s
%s: DOMDocument::loadXML(): %s
bool(true)
Done
4 changes: 4 additions & 0 deletions ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ libxml
dom
xml
simplexml
--SKIPIF--
<?php
if (preg_match('/[^\x00-\x7F]/', __DIR__)) die('skip path contains non-ASCII characters that libxml URI parser rejects');
?>
--FILE--
<?php

Expand Down
4 changes: 4 additions & 0 deletions ext/xmlreader/tests/012.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
XMLReader: accessing empty and non existing attributes
--EXTENSIONS--
xmlreader
--SKIPIF--
<?php
if (preg_match('/[^\x00-\x7F]/', __DIR__)) die('skip path contains non-ASCII characters that libxml URI parser rejects');
?>
--FILE--
<?php

Expand Down
Loading