fpm: Convert to new internal polling API#22796
Open
NattyNarwhal wants to merge 8 commits into
Open
Conversation
Member
|
I don't have much time for a proper review but this might be too risky for 8.6 anyway so I will take a look once new version is branched. |
bukka
requested changes
Jul 21, 2026
bukka
left a comment
bukka
left a comment
Member
There was a problem hiding this comment.
We should also wait for timeout poll event to be added as it will make things nicer then.
You may need to hack up the poll backends to not return an error on EINTR. Passes a lot of tests, but need to deal with leak strategy.
Allocate the buffer at the beginning. There is a bit of glue for going between the linked list that FPM uses for record keeping vs. the buffer of FDs that poll API returns, but it's minimal. This does leak memory, so a few more tests fail. Need to figure out strategy for that.
In the poll/kqueue/epoll backends, these would return an error without a warning or processing the results. Do the same here. Note that the old fpm Solaris event ports backend could handle the case of EINTR/ETIME with returned results. I don't think the internal polling API handles that, but I don't have a Solaris system to test with.
Don't use ZendMM; relocate comment to more sensible spot.
Member
Author
I think this makes sense. (FWIW, I was looking at implementing a new poll backend, so that's why I was interested making FPM use that to avoid reimplementing one twice. That'll also probably have to wait for 8.7 or so...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very hacky first pass! Gets rid of FPM's own polling backends (only select is the casualty, everything else is handled by the new polling API). The polling API also has some stuff for persistent allocations, and FPM is the first internal consumer it seems.
Testing so far on macOS (kqueue) and Linux (epoll),
Concerns so far:
EINTR, internal polling API does not. Moved EINTR ignoring to fpm's loop, but may be a problem on Solaris?