Update unit tests for IBM i PASE#22837
Draft
NattyNarwhal wants to merge 7 commits into
Draft
Conversation
locale -a returns some bogus locales that segfault if you load them. Skip them in this test.
I don't have an AIX system to test this with, but I suspect this is also true for AIX, since Solaris has the same limitation and System V heritage as well.
While it can use BSD-style niceness, it defaults to System V style niceness, like how Solaris is. Documented in https://www.ibm.com/docs/en/aix/7.2.0?topic=g-getpriority-setpriority-nice-subroutine
For the other proc_nice test, we skip on AIX family stuff, so it wouldn't matter there.
IBM i doesn't have it here. I suspect this test could probably be rewritten to not use it, but let's keep the logic the same for now.
Which doesn't seem to be in /etc/services, but another, funnier location. We could also just skip imap here. I have not skipped on AIX family, since I'm unsure if AIX is also missing imap from this list as well. It seems plausible if Solaris is also missing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly cosmetic stuff on tests and platform differences. Sometimes these are behaviours shared with AIX, but since I don't have access to an AIX system, I only mark AIX when I can verify via docs or strongly suspect it to be the case (i.e. Solaris also being special in the same way).
There are a few more tests that fail, but I'm investigating those more throughly, as a lot are i.e. more complicated filesystem behaviour differences.