streams: _php_stream_open_wrapper_ex() refactor#22839
Open
Girgias wants to merge 3 commits into
Open
Conversation
Girgias
changed the title
Girgias
force-pushed
the
2026-07-stream-opener-refactor
branch
2 times, most recently
from
July 20, 2026 23:44
898a212 to
df2a7ae
Compare
Girgias
force-pushed
the
2026-07-stream-opener-refactor
branch
from
July 21, 2026 12:15
df2a7ae to
bc59e65
Compare
Instead of the old way of logging errors and displaying them use the new APIs.
Girgias
force-pushed
the
2026-07-stream-opener-refactor
branch
from
July 21, 2026 12:19
bc59e65 to
0d530e5
Compare
Girgias
marked this pull request as ready for review
July 21, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent of #22836 for
_php_stream_open_wrapper_ex().The motivation is make the code more legible and the execution flow clearer.
Use the newer stream error APIs.
And in the future hopefully let the wrapper hook handle the
REPORT_ERRORoption directly rather than negating the flag. As currently if the wrapper hook emits errors and returns a stream, those errors are suppressed.