fix(extended-text-entry): re-render elements on reconnect PIE-672#3050
Merged
Conversation
The configure element had no connectedCallback while its disconnectedCallback unmounts the React root and sets _root = null. When a host (e.g. Vue keep-alive) detached and re-attached the same element instance without re-assigning model/configuration, nothing re-rendered and the settings panel stayed blank until render() was called manually. Add connectedCallback that calls render() (matching the categorize/select-text configure elements) so it re-renders on reconnect; render() already guards on _model and recreates _root when null, so this is safe and idempotent. Also null _root in the player element's disconnectedCallback so that a reconnect render() recreates the root instead of calling render() on an already-unmounted root. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configure element had no connectedCallback while its disconnectedCallback unmounts the React root and sets _root = null. When a host (e.g. Vue keep-alive) detached and re-attached the same element instance without re-assigning model/configuration, nothing re-rendered and the settings panel stayed blank until render() was called manually. Add connectedCallback that calls render() (matching the categorize/select-text configure elements) so it re-renders on reconnect; render() already guards on _model and recreates _root when null, so this is safe and idempotent.
Also null _root in the player element's disconnectedCallback so that a reconnect render() recreates the root instead of calling render() on an already-unmounted root.
https://illuminate.atlassian.net/browse/PIE-672