Skip to content

lake: add Iceberg table docs#23301

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
awxxxxxx:agent/remove-iceberg-engine-guidance
Jul 21, 2026
Merged

lake: add Iceberg table docs#23301
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
awxxxxxx:agent/remove-iceberg-engine-guidance

Conversation

@awxxxxxx

@awxxxxxx awxxxxxx commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

Rewrite the Apache Iceberg table documentation as a concise TiDB Cloud Lake reference:

  • remove quick starts, sample queries, command output, and example sections
  • retain catalog syntax, connection parameters, supported catalog types, data type mappings, cache refresh, write syntax, and Iceberg table functions
  • restore the Apache Iceberg page in the Table Engines overview and TiDB Cloud Lake TOC

The Iceberg entry was hidden in #23116 because the page still contained content that was not suitable for public TiDB Cloud Lake documentation. This PR cleans up that page before exposing the entry again.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Added Apache Iceberg™ Tables to the SQL Reference table of contents and available table engines.
    • Reorganized and streamlined the Iceberg Tables guide with updated catalog creation, supported catalog types, querying, data type mappings, metadata refresh, and write syntax.
    • Added clearer guidance on Iceberg use cases, lakehouse catalogs, time travel, and schema evolution.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. contribution This PR is from a community contributor. labels Jul 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Iceberg table engine option from the documentation on choosing a table engine in table-engines.md. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@awxxxxxx
awxxxxxx force-pushed the agent/remove-iceberg-engine-guidance branch from 4467496 to 209ca7e Compare July 17, 2026 02:26
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2026
@awxxxxxx awxxxxxx changed the title lake: remove stale Iceberg engine guidance lake: clean up and publish Iceberg table docs Jul 17, 2026
@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Jul 17, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jul 17, 2026
@lilin90 lilin90 changed the title lake: clean up and publish Iceberg table docs lake: add Iceberg table docs Jul 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@wubx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@awxxxxxx
awxxxxxx marked this pull request as ready for review July 21, 2026 06:16
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 76d195a1-eb84-473d-a3df-31ba79aee351

📥 Commits

Reviewing files that changed from the base of the PR and between 209ca7e and 1362844.

📒 Files selected for processing (1)
  • tidb-cloud-lake/sql/apache-icebergtm-tables.md
💤 Files with no reviewable changes (1)
  • tidb-cloud-lake/sql/apache-icebergtm-tables.md

📝 Walkthrough

Walkthrough

The Iceberg SQL reference is substantially rewritten with updated catalog syntax, supported catalog types, query commands, type mappings, cache refresh guidance, table-writing syntax, and metadata functions. Navigation and the available table engines list now include Apache Iceberg™ Tables.

Changes

Iceberg documentation

Layer / File(s) Summary
Iceberg overview and discovery
tidb-cloud-lake/sql/apache-icebergtm-tables.md, TOC-tidb-cloud-lake.md, tidb-cloud-lake/sql/table-engines.md
Adds overview and usage guidance and lists Apache Iceberg™ Tables in the lake documentation navigation and engine table.
Catalog creation and querying
tidb-cloud-lake/sql/apache-icebergtm-tables.md
Documents updated CREATE CATALOG syntax and parameters, supported catalog types, catalog commands, and Iceberg query forms.
Table types, caching, and writes
tidb-cloud-lake/sql/apache-icebergtm-tables.md
Updates type mappings, cache refresh instructions, table creation and insertion syntax, partition guidance, and Iceberg metadata functions.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding Iceberg table documentation.
Description check ✅ Passed The description covers the required change summary, affected version, related link, and AI involvement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fdcbd4ea-c61f-430b-833b-cb4b82f34a1c

📥 Commits

Reviewing files that changed from the base of the PR and between 344e2b1 and 209ca7e.

📒 Files selected for processing (3)
  • TOC-tidb-cloud-lake.md
  • tidb-cloud-lake/sql/apache-icebergtm-tables.md
  • tidb-cloud-lake/sql/table-engines.md

Comment thread tidb-cloud-lake/sql/apache-icebergtm-tables.md
Comment thread tidb-cloud-lake/sql/table-engines.md
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 21, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-21 06:22:51.167874406 +0000 UTC m=+1299557.203969462: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Jul 21, 2026
@lilin90

lilin90 commented Jul 21, 2026

Copy link
Copy Markdown
Member

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 21, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit c874202 into pingcap:release-8.5 Jul 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants